Created attachment 38992 [details] Screenshot of broken paging The recent comments paging is displayig the 'current' page to the right side of the paging list. (see screenshot) In order to test this you need to activate the page via system preference and then add 21+ comments to different records in your catalog. There is also a small bug, as we are missing a space before the 'by' in each entry. Verified on a somewhat recent master and a 3.18.5.1 installation.
Created attachment 39756 [details] [review] Bug 14173: Paging on 'recent comments' page in OPAC is not displaying correctly This patch corrects the display of current page on a multipage recent comments. To test: 1) Enable OpacShowRecentComments 2) Add multiple comments to multiple records I used a script to add multiple lines like "insert into reviews values ($i, 51, $i, 'Comment $i', 1, '2015-06-01 00:00:00')" to table reviews 3) On OPAC, go to 'Recent comments', verify the bug 4) Apply the patch 5) Reload and check correct display Can't found missing space near 'by' from description. Display is correct for me.
Created attachment 39759 [details] [review] [Signed-off] Bug 14173: Paging on 'recent comments' page in OPAC is not displaying correctly This patch corrects the display of current page on a multipage recent comments. To test: 1) Enable OpacShowRecentComments 2) Add multiple comments to multiple records I used a script to add multiple lines like "insert into reviews values ($i, 51, $i, 'Comment $i', 1, '2015-06-01 00:00:00')" to table reviews 3) On OPAC, go to 'Recent comments', verify the bug 4) Apply the patch 5) Reload and check correct display Can't found missing space near 'by' from description. Display is correct for me. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Setting to P3 since usability of OPAC is affected.
Created attachment 39799 [details] [review] Bug 14173: Paging on 'recent comments' page in OPAC is not displaying correctly This patch corrects the display of current page on a multipage recent comments. To test: 1) Enable OpacShowRecentComments 2) Add multiple comments to multiple records I used a script to add multiple lines like "insert into reviews values ($i, 51, $i, 'Comment $i', 1, '2015-06-01 00:00:00')" to table reviews 3) On OPAC, go to 'Recent comments', verify the bug 4) Apply the patch 5) Reload and check correct display Can't found missing space near 'by' from description. Display is correct for me. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Tested on master, 3.20, 3.18, 3.16 and 3.14, the bug exist on all versions and the patch fixes it!
Patch pushed to master. Good catch Bernardo!
Pushed to 3.20.x will be in 3.20.1
Liz, can you pick this for 3.18 maybe?
Patch pushed to 3.18.x will be in 3.18.08
Pushed to 3.16.x, will be in 3.16.13