Code contains: window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&index=\" + i + \"&result=\"+defaultvalue,\"marc21_field_7\"+i+\"\",'width=900,height=700,toolbar=false,scrollbars=yes'); The part ,\"marc21_field_7\"+i+\"\", is somewhat unexpected. If I am correct, js could interpret this as the name parameter of window.open. Note that this name is not the title. I propose to remove it.
Created attachment 41004 [details] [review] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links
Created attachment 44451 [details] [review] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links Signed-off-by: Fredreic Demians <f.demians@tamil.fr> Plugin still working, with a valid pop-pup window id.
Created attachment 44583 [details] [review] [PASSED QA] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links Signed-off-by: Fredreic Demians <f.demians@tamil.fr> Plugin still working, with a valid pop-pup window id. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Marcel!