An attempt to remove a language that is not installed shows the message: "Error: the selected language is not already installed." I feel that it will be nicer to just have "Error: the selected language is not installed."
Created attachment 39202 [details] [review] Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed."
Created attachment 39204 [details] [review] [SIGNED OFF] Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 39422 [details] [review] Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 39423 [details] [review] [PASSED QA] Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by <installdir>/debian/scripts/koha-translate --remove <langcode> 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment on attachment 39423 [details] [review] [PASSED QA] Bug 14203 - Message for non-existent lang removal Obsoleting because Jonathan beat me to it!
Patch pushed to master. Thanks Indranil!
Pushed to 3.20.x will be in 3.20.1
Patch pushed to 3.18.x will be in 3.18.08
Pushed to 3.16.x, will be in 3.16.13