Created attachment 39464 [details] [review] Bug 14264: Fix export of late orders when translated Bug 7298 tried to fix this issue, but it was not correct. We have 3 files in acqui/csv: basketgroup.tt, basket.tt and lateorders.tt The first 2 don't contain translatable string, and are not modified on translating the templates (`translate install`) On the contrary, lateorders.tt has some strings to translate ('Author:', 'Published by:', etc.). After being translated, all carriage returns between TT tags are removed. Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to acqui/lateorders.pl using this language 3/ Generate a csv for 1+ late orders and confirm the first line only contains the headers.
Hi Jonathan, I tested with de-DE - but it didn't work somehow. Could you take another look please?
Created attachment 40177 [details] [review] Bug 14264: Fix export of late orders when translated Bug 7298 tried to fix this issue, but it was not correct. We have 3 files in acqui/csv: basketgroup.tt, basket.tt and lateorders.tt The first 2 don't contain translatable string, and are not modified on translating the templates (`translate install`) On the contrary, lateorders.tt has some strings to translate ('Author:', 'Published by:', etc.). After being translated, all carriage returns between TT tags are removed. Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to acqui/lateorders.pl using this language 3/ Generate a csv for 1+ late orders and confirm the first line only contains the headers.
Tested OK on biblibre sandbox following test plan (french translation) : the csv first line only contains the headers.
Created attachment 45046 [details] [review] [PASSED QA] Bug 14264: Fix export of late orders when translated Bug 7298 tried to fix this issue, but it was not correct. We have 3 files in acqui/csv: basketgroup.tt, basket.tt and lateorders.tt The first 2 don't contain translatable string, and are not modified on translating the templates (`translate install`) On the contrary, lateorders.tt has some strings to translate ('Author:', 'Published by:', etc.). After being translated, all carriage returns between TT tags are removed. Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to acqui/lateorders.pl using this language 3/ Generate a csv for 1+ late orders and confirm the first line only contains the headers. Signed-off-by: Laurence Lefaucheur <laurence.lefaucheur@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
This patch has been pushed to 3.20.x, will be in 3.20.6.
Pushed to 3.18.13, and released.
This is broken again - see bug 17795.