At the moment, we use both jQuery's $.trim() and the regular Javascript trim() in our templates. You can find trim() in: - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt - koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt You can find $.trim() in: - koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt The jQuery $.trim() appears perfectly cross-platform, but the Javascript trim() isn't supported in IE8 or earlier. It was only introduced in IE9. Since we already use jQuery everywhere, I don't see why we can't use $.trim() instead of trim(). At the moment, people using IE8 in the staff client (and I'm sure there are many of them) can't save patron categories. Javascript errors will prevent the submission of the page. -- I know we occasionally debate supporting older versions of IE, but this is a pretty easy win.
Created attachment 39468 [details] [review] Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt This patch replaces trim() with $.trim() in admin/categorie.tt, as $.trim() is more cross-platform (ie it is supported in "< IE9"). _TEST PLAN_ Before applying patch: 0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools 1) Go to Administration > Patron categories 2) Click "Edit" next to a category 3) Click "Save" at the bottom 4) Note the form doesn't submit (you can also notice the error in the console log) Apply the patch: 5) Hold down shift + refresh the page 6) Click "Save" at the bottom" 7) Note that the form does submit and there are no errors reported
Created attachment 39486 [details] [review] Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt This patch replaces trim() with $.trim() in admin/categorie.tt, as $.trim() is more cross-platform (ie it is supported in "< IE9"). _TEST PLAN_ Before applying patch: 0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools 1) Go to Administration > Patron categories 2) Click "Edit" next to a category 3) Click "Save" at the bottom 4) Note the form doesn't submit (you can also notice the error in the console log) Apply the patch: 5) Hold down shift + refresh the page 6) Click "Save" at the bottom" 7) Note that the form does submit and there are no errors reported Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Created attachment 39593 [details] [review] Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt This patch replaces trim() with $.trim() in admin/categorie.tt, as $.trim() is more cross-platform (ie it is supported in "< IE9"). _TEST PLAN_ Before applying patch: 0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools 1) Go to Administration > Patron categories 2) Click "Edit" next to a category 3) Click "Save" at the bottom 4) Note the form doesn't submit (you can also notice the error in the console log) Apply the patch: 5) Hold down shift + refresh the page 6) Click "Save" at the bottom" 7) Note that the form does submit and there are no errors reported Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> No regression found using iceweasel. I did not know the staff interface was IE compatible.
Patch pushed to master. Thanks David!
Pushed to 3.20.x will be in 3.20.1
Patch pushed to 3.18.x will be in 3.18.08