Bug 14284 - Typo in Languages.pm
Summary: Typo in Languages.pm
Status: RESOLVED DUPLICATE of bug 12017
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P3 trivial (vote)
Assignee: Indranil Das Gupta
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-28 00:24 UTC by Indranil Das Gupta
Modified: 2015-05-28 18:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14284 - Fixes typo 'native_descrition' (1.38 KB, patch)
2015-05-28 00:41 UTC, Indranil Das Gupta
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Indranil Das Gupta 2015-05-28 00:24:24 UTC
Line #102 reads as follows:

'native_descrition'=>$language_set->{language_native_description} }

should read :

'native_description'=>$language_set->{language_native_description} }
Comment 1 Indranil Das Gupta 2015-05-28 00:41:09 UTC
Created attachment 39624 [details] [review]
Bug 14284 - Fixes typo 'native_descrition'

Fixes the following typo (originally line 102 in C4/Languages.pm):
'native_descrition'=>$language_set->{language_native_description} }

to read:
'native_description'=>$language_set->{language_native_description} }

Test plan
=========

1/ in your git installdir do a `grep -R native native_descrition`.
   it should return only one single reference to this line in
   C4/Languages.pm
2/ open the file C4/Languages.pm, go to line #102 to confirm it.
   close the file
3/ apply patch
4/ re-run `grep -R native native_descrition`, this time nothing
   should be returned.
Comment 2 Mark Tompsett 2015-05-28 02:51:31 UTC
Someone missed that?! Write some tests, so I can sign this sucker off!
Comment 3 Mark Tompsett 2015-05-28 14:56:52 UTC
Bug 12017 has a patch piece that removes this function completely. I'm sure the correct course of action will be taken with respect to this function (getFrameworkLanguages) there.

*** This bug has been marked as a duplicate of bug 12017 ***
Comment 4 Bernardo Gonzalez Kriegel 2015-05-28 15:38:35 UTC
(In reply to M. Tompsett from comment #3)
> Bug 12017 has a patch piece that removes this function completely. I'm sure
> the correct course of action will be taken with respect to this function
> (getFrameworkLanguages) there.
> 

Was about to said that, it's dead code
Comment 5 Indranil Das Gupta 2015-05-28 18:05:06 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #4)
> (In reply to M. Tompsett from comment #3)
> > Bug 12017 has a patch piece that removes this function completely. I'm sure
> > the correct course of action will be taken with respect to this function
> > (getFrameworkLanguages) there.
> > 
> 
> Was about to said that, it's dead code

bgkriegel++ for 12017! :)