Sometimes the today's checkouts do not sort correctly. This is due to a simple type in the comparison line where the bad key 'timstamp' is compared against the correct key 'timestamp'.
Created attachment 39687 [details] [review] Bug 14299 - Today's checkouts not always sorting correctly Sometimes the today's checkouts do not sort correctly. This is due to a simple type in the comparison line where the bad key 'timstamp' is compared against the correct key 'timestamp'. Test Plan: 1) Check out a decent number of items in a row ( 5+ ) 2) Hopefully you will see they are sorted incorrectly 3) Apply this patch 4) Reload the page 5) Note they are now sorted correctly
There is a typo in my description ; ) I wrote 'type' instead of 'typo'.
Created attachment 39688 [details] [review] Bug 14299 - Today's checkouts not always sorting correctly Sometimes the today's checkouts do not sort correctly. This is due to a simple typo in the comparison line where the bad key 'timstamp' is compared against the correct key 'timestamp'. Test Plan: 1) Check out a decent number of items in a row ( 5+ ) 2) Hopefully you will see they are sorted incorrectly 3) Apply this patch 4) Reload the page 5) Note they are now sorted correctly
Created attachment 39743 [details] [review] [Signed-off] Bug 14299 - Today's checkouts not always sorting correctly Sometimes the today's checkouts do not sort correctly. This is due to a simple typo in the comparison line where the bad key 'timstamp' is compared against the correct key 'timestamp'. Test Plan: 1) Check out a decent number of items in a row ( 5+ ) 2) Hopefully you will see they are sorted incorrectly 3) Apply this patch 4) Reload the page 5) Note they are now sorted correctly Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 39810 [details] [review] Bug 14299 - Today's checkouts not always sorting correctly Sometimes the today's checkouts do not sort correctly. This is due to a simple typo in the comparison line where the bad key 'timstamp' is compared against the correct key 'timestamp'. Test Plan: 1) Check out a decent number of items in a row ( 5+ ) 2) Hopefully you will see they are sorted incorrectly 3) Apply this patch 4) Reload the page 5) Note they are now sorted correctly Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Patch pushed to master. Thanks Kyle!
Pushed to 3.20.x will be in 3.20.1
Patch pushed to 3.18.x will be in 3.18.08