This bug pretend to complement the bug 14198. This will modify the XSLT in Intranet and OPAC to display the link for Publisher, Distributor, Manufacuter, copyright in XSLTs.
Created attachment 42178 [details] [review] Bug 14304 - RDA: Display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing. Test plan 1) Follow test plan for bug 14198 2) Apply the bug 14198 3) Do a search by pv: or pb: 4) Look that there no display link for 264 field. 5) Apply the patch 6) In a like maner of step 3 and 4, check out the new link for 264 field. 7) Check out the display link in OPAC and staff clint Sponsored-by: Universidad de El Salvador
Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl Failed to merge in the changes.
(In reply to Nick Clemens from comment #2) I'll fix it up as soon as possible, Nick. Thanks for testing.
(In reply to Héctor Eduardo Castro Avalos from comment #3) > (In reply to Nick Clemens from comment #2) > > I'll fix it up as soon as possible, Nick. > > Thanks for testing. Hi, I recently tested this patch on Koha-3.20.6, the patch applied and works well! :) But I discovered a small display bug, after this patch... The 264 subfields are not repeated, as expected https://www.oclc.org/bibformats/en/2xx/264.html
Hi Mason, can you give an example? I noticed on our 3.22 test installaton that the label seems to be repeated for each 264 without this patch already. Wonder if this is the same issue you noticed?
Created attachment 47632 [details] a pic of 264x display bug in OPAC, where repeated 264x subfields are not displayed
(In reply to Katrin Fischer from comment #5) > Hi Mason, can you give an example? I noticed on our 3.22 test installaton > that the label seems to be repeated for each 264 without this patch already. > Wonder if this is the same issue you noticed? oops... i'm testing on a 3.20.6 Koha here. i'll try to confirm on master
Hi All I will try to work in this patch as soon as possible. I need to do a little of time. Thank you for keep testing, Mason.
Created attachment 47677 [details] [review] Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador
I will send the OPAC's patch afterwards
Created attachment 47700 [details] [review] Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for field 264/bug 14198 and reflect the Zebra index 'Provider' in detail page for OPAC screen. To test: follow previous test plan
Hi The patches are ready to be tested Regards
Still applies...
I think there is something odd about the display - the result list seems to display all 264, while the detail view does only display one/some? But... totally unrelated to this patch - which works.
Created attachment 48481 [details] [review] [SIGNED OFF] Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 48482 [details] [review] [SIGNED OFF] Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for field 264/bug 14198 and reflect the Zebra index 'Provider' in detail page for OPAC screen. To test: follow previous test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 49582 [details] [review] Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 49583 [details] [review] Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for field 264/bug 14198 and reflect the Zebra index 'Provider' in detail page for OPAC screen. To test: follow previous test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the May 2016 Release. Thanks!