Bug 14304 - RDA: Display link in XSLT for 264 field to reflect Zebra indexing
Summary: RDA: Display link in XSLT for 264 field to reflect Zebra indexing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Héctor Eduardo Castro Avalos
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 14198
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-01 04:43 UTC by Héctor Eduardo Castro Avalos
Modified: 2016-12-05 21:27 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14304 - RDA: Display link in XSLT for 264 field to reflect Zebra indexing (10.98 KB, patch)
2015-09-01 17:05 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
a pic of 264x display bug in OPAC, where repeated 264x subfields are not displayed (217.03 KB, image/png)
2016-02-04 07:25 UTC, Mason James
Details
Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing (6.23 KB, patch)
2016-02-05 07:00 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing (5.62 KB, patch)
2016-02-05 14:45 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[SIGNED OFF] Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing (6.30 KB, patch)
2016-02-29 23:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED OFF] Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing (5.68 KB, patch)
2016-02-29 23:22 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing (6.39 KB, patch)
2016-03-25 09:25 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing (5.77 KB, patch)
2016-03-25 09:26 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Héctor Eduardo Castro Avalos 2015-06-01 04:43:23 UTC
This bug pretend to complement the bug 14198. This will modify the XSLT in Intranet and OPAC to display the link for Publisher, Distributor, Manufacuter, copyright in XSLTs.
Comment 1 Héctor Eduardo Castro Avalos 2015-09-01 17:05:12 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2015-11-24 19:49:04 UTC
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
Failed to merge in the changes.
Comment 3 Héctor Eduardo Castro Avalos 2015-11-25 14:25:32 UTC
(In reply to Nick Clemens from comment #2)

I'll fix it up as soon as possible, Nick.

Thanks for testing.
Comment 4 Mason James 2016-02-04 07:01:22 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #3)
> (In reply to Nick Clemens from comment #2)
> 
> I'll fix it up as soon as possible, Nick.
> 
> Thanks for testing.

Hi, I recently tested this patch on Koha-3.20.6, the patch applied and works well! :)
But I discovered a small display bug, after this patch...

The 264 subfields are not repeated, as expected
 https://www.oclc.org/bibformats/en/2xx/264.html
Comment 5 Katrin Fischer 2016-02-04 07:04:46 UTC
Hi Mason, can you give an example? I noticed on our 3.22 test installaton that the label seems to be repeated for each 264 without this patch already. Wonder if this is the same issue you noticed?
Comment 6 Mason James 2016-02-04 07:25:54 UTC
Created attachment 47632 [details]
a pic of 264x display bug in OPAC, where repeated 264x subfields are not displayed
Comment 7 Mason James 2016-02-04 07:28:54 UTC
(In reply to Katrin Fischer from comment #5)
> Hi Mason, can you give an example? I noticed on our 3.22 test installaton
> that the label seems to be repeated for each 264 without this patch already.
> Wonder if this is the same issue you noticed?

oops... i'm testing on a 3.20.6 Koha here. 

i'll try to confirm on master
Comment 8 Héctor Eduardo Castro Avalos 2016-02-04 14:27:14 UTC
Hi All

I will try to work in this patch as soon as possible. I need to do a little of time. Thank you for keep testing, Mason.
Comment 9 Héctor Eduardo Castro Avalos 2016-02-05 07:00:31 UTC Comment hidden (obsolete)
Comment 10 Héctor Eduardo Castro Avalos 2016-02-05 07:05:56 UTC
I will send the OPAC's patch afterwards
Comment 11 Héctor Eduardo Castro Avalos 2016-02-05 14:45:47 UTC Comment hidden (obsolete)
Comment 12 Héctor Eduardo Castro Avalos 2016-02-05 14:56:20 UTC
Hi

The patches are ready to be tested

Regards
Comment 13 Héctor Eduardo Castro Avalos 2016-02-29 16:06:28 UTC
Still applies...
Comment 14 Katrin Fischer 2016-02-29 23:19:00 UTC
I think there is something odd about the display - the result list seems to display all 264, while the detail view does only display one/some? But... totally unrelated to this patch - which works.
Comment 15 Katrin Fischer 2016-02-29 23:21:48 UTC Comment hidden (obsolete)
Comment 16 Katrin Fischer 2016-02-29 23:22:17 UTC Comment hidden (obsolete)
Comment 17 Marcel de Rooy 2016-03-25 09:25:43 UTC
Created attachment 49582 [details] [review]
Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing

This patch add display link in XSLT for 264 for bug 14198 and reflect the
Zebra indexing 'Provider' in detail page for Intranet.

Test plan
1) Update zebra index if no Provider: index exist
2) Do a search by Provider:
3) Goto detail page for a record with 264
4) Look that there no display link for 264 field.
5) Apply the patch
6) Reload the page, notice about the link, click the link an confirm
   the new index Provider works fine
7) Test with multiple records with 260 and 264, if you prefer follow test plan
   for bug 14734
8) Access an RCAA2 record just with 260 field
9) Notice that 260 has been updated with Provider index too.
NOTE: The intention of Provider index -according with documentation- is
to collect multiples fields including 260, 264, 270, and 257

Sponsored-by: Universidad de El Salvador

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 18 Marcel de Rooy 2016-03-25 09:26:16 UTC
Created attachment 49583 [details] [review]
Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing

This patch add display link in XSLT for field 264/bug 14198 and reflect the
Zebra index 'Provider' in detail page for OPAC screen.

To test: follow previous test plan

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 19 Brendan Gallagher 2016-03-25 22:03:27 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!