To reproduce: - Allow commenting in OPAC (Syspref reviewson) - Log in to OPAC - Do a search with many results - Click on a biblio in result list - Verify that you can browse the results in detail view ("Browse results") - Repeat teh search above - Click on the same biblio as above - Add a comment (Tab "Comments") - Close commenting window - Click on "Next" in result browser Result: The next biblio is displayed, but result browser has disappeared. I reproduced this with Firefox and Chrome.
Created attachment 39760 [details] [review] Bug 14313 - OPAC: Adding a comment makes result browser disappear To reproduce: - Allow commenting in OPAC (Syspref reviewson) - Log in to OPAC - Do a search with many results - Click on a biblio in result list - Verify that you can browse the results in detail view ("Browse results") - Repeat teh search above - Click on the same biblio as above - Add a comment (Tab "Comments") - Close commenting window - Click on "Next" in result browser Result: The next biblio is displayed, but result browser has disappeared. To test: - Apply patch - Try to reproduce issue above, verify that result browser does no longer disappear
Created attachment 39761 [details] [review] Bug 14313 - OPAC: Adding a comment makes result browser disappear To reproduce: - Allow commenting in OPAC (Syspref reviewson) - Log in to OPAC - Do a search with many results - Click on a biblio in result list - Verify that you can browse the results in detail view ("Browse results") - Repeat teh search above - Click on the same biblio as above - Add a comment (Tab "Comments") - Close commenting window - Click on "Next" in result browser Result: The next biblio is displayed, but result browser has disappeared. To test: - Apply patch - Try to reproduce issue above, verify that result browser does no longer disappear AMended to remove whitespace chars. / MV
Created attachment 39767 [details] [review] [SIGNED-OFF] Bug 14313: OPAC - Adding a comment makes result browser disappear To reproduce: - Allow commenting in OPAC (Syspref reviewson) - Log in to OPAC - Do a search with many results - Click on a biblio in result list - Verify that you can browse the results in detail view ("Browse results") - Repeat teh search above - Click on the same biblio as above - Add a comment (Tab "Comments") - Close commenting window - Click on "Next" in result browser Result: The next biblio is displayed, but result browser has disappeared. To test: - Apply patch - Try to reproduce issue above, verify that result browser does no longer disappear AMended to remove whitespace chars. / MV Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bug & solution checked, works well. No koha-qa errors
Created attachment 39801 [details] [review] Bug 14313: OPAC - Adding a comment makes result browser disappear To reproduce: - Allow commenting in OPAC (Syspref reviewson) - Log in to OPAC - Do a search with many results - Click on a biblio in result list - Verify that you can browse the results in detail view ("Browse results") - Repeat teh search above - Click on the same biblio as above - Add a comment (Tab "Comments") - Close commenting window - Click on "Next" in result browser Result: The next biblio is displayed, but result browser has disappeared. To test: - Apply patch - Try to reproduce issue above, verify that result browser does no longer disappear AMended to remove whitespace chars. / MV Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Bug & solution checked, works well. No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Patch pushed to master. Thanks Marc!
Pushed to 3.20.x will be in 3.20.1
Pushed to 3.18.x will be in 3.18.09