The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber.
Created attachment 39899 [details] [review] Bug 14338 - Unable to delete patron images The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber. Test Plan: 1) Upload a patron image 2) Attempt to delete patron image 3) Image will remain 4) Apply this patch 5) Attempt to delete patron image 6) Image will be removed
DOH! I figured out why it worked for me. my borrowernumber = cardnumber!
Created attachment 39904 [details] [review] Bug 14338 - Unable to delete patron images The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber. Test Plan: 1) Upload a patron image 2) Ensure the card number is not the same as the borrower number 3) Attempt to delete patron image -- Image will remain 4) Apply this patch 5) Attempt to delete patron image -- Image will be removed 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 39947 [details] [review] [PASSED QA] Bug 14338 - Unable to delete patron images The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber. Test Plan: 1) Upload a patron image 2) Ensure the card number is not the same as the borrower number 3) Attempt to delete patron image -- Image will remain 4) Apply this patch 5) Attempt to delete patron image -- Image will be removed 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Kyle!
Pushed to 3.20.x will be in 3.20.1
Patch pushed to 3.18.x will be in 3.18.08
Skipping for 3.16.x series, due to patch conflicts
Created attachment 41186 [details] [review] Bug 14338 - Unable to delete patron images [3.16.x] The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber. Test Plan: 1) Upload a patron image 2) Ensure the card number is not the same as the borrower number 3) Attempt to delete patron image -- Image will remain 4) Apply this patch 5) Attempt to delete patron image -- Image will be removed 6) run koha qa test tools NOTE: Deletion worked in 3.16.x, though the message for debugging differed (cardnumber vs. borrowernumber). This effectively removes cardnumber from the URL and messages for the delete operation. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to M. Tompsett from comment #9) > Created attachment 41186 [details] [review] [review] > Bug 14338 - Unable to delete patron images [3.16.x] Pushed to 3.16.x, will be in 3.16.13. cheers Mark :)