The introduction of the new Koha::Config::SysPrefs package slightly changed the behaviour on syspref retrieval by not catching DB errors (notably when there is no DB structure :-/, which should be detected and redirected to the installer/maintenance depending on the interface)
Created attachment 39906 [details] [review] Bug 14339: C4::Context->preference should return undef if DB is not populated The current behaviour for C4::Context->preference when the DB is not still populated with tables is to return undef. This is used by C4::Auth to identify the need of running the installer. This behaviour got broken by bug 13967, which lets DB errors to escalate and thus Koha gets broken instead of prompting for install. This patch wraps Koha::Config::Sysprefs->find inside an eval and sets undef if needed. To test: - In current master, drop the DB - Load OPAC and Intranet => FAIL: notice an ugly software error. - Apply the patch - Load the OPAC => SUCCESS: Maintenance mode screen is shown - Load Intranet => SUCCESS: You are prompted the DB credentials to run the web installer. - Sign off :-D Tomas
Created attachment 39909 [details] [review] Bug 14339: C4::Context->preference should return undef if DB is not populated The current behaviour for C4::Context->preference when the DB is not still populated with tables is to return undef. This is used by C4::Auth to identify the need of running the installer. This behaviour got broken by bug 13967, which lets DB errors to escalate and thus Koha gets broken instead of prompting for install. This patch wraps Koha::Config::Sysprefs->find inside an eval and sets undef if needed. To test: - In current master, drop the DB - Load OPAC and Intranet => FAIL: notice an ugly software error. - Apply the patch - Load the OPAC => SUCCESS: Maintenance mode screen is shown - Load Intranet => SUCCESS: You are prompted the DB credentials to run the web installer. - Sign off :-D Tomas Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 39917 [details] [review] [PASSED QA] Bug 14339: C4::Context->preference should return undef if DB is not populated The current behaviour for C4::Context->preference when the DB is not still populated with tables is to return undef. This is used by C4::Auth to identify the need of running the installer. This behaviour got broken by bug 13967, which lets DB errors to escalate and thus Koha gets broken instead of prompting for install. This patch wraps Koha::Config::Sysprefs->find inside an eval and sets undef if needed. To test: - In current master, drop the DB - Load OPAC and Intranet => FAIL: notice an ugly software error. - Apply the patch - Load the OPAC => SUCCESS: Maintenance mode screen is shown - Load Intranet => SUCCESS: You are prompted the DB credentials to run the web installer. - Sign off :-D Tomas Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 39923 [details] [review] [PASSED QA] Bug 14339: C4::Context->preference should return undef if DB is not populated The current behaviour for C4::Context->preference when the DB is not still populated with tables is to return undef. This is used by C4::Auth to identify the need of running the installer. This behaviour got broken by bug 13967, which lets DB errors to escalate and thus Koha gets broken instead of prompting for install. This patch wraps Koha::Config::Sysprefs->find inside an eval and sets undef if needed. To test: - In current master, drop the DB - Load OPAC and Intranet => FAIL: notice an ugly software error. - Apply the patch - Load the OPAC => SUCCESS: Maintenance mode screen is shown - Load Intranet => SUCCESS: You are prompted the DB credentials to run the web installer. - Sign off :-D Tomas Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master.