Created attachment 39905 [details] Numbered links have incorrect url Links to result pages don't work in Receive Shipment List (but fortunately, Next and Previous buttons work) It's because the booksellerid is not furnished in the url. Test Plan : 1) Go to Acquisitions module, enter a bookseller name that you know you can get many page of invoices for and search for it. 2) click on Receive shipment button. 3) On bottom of the first results page, click on page number 2 link. (cf joined screencast) You'll see that the results include invoices from other booksellerid. Indeed, I suppose that you get results from all booksellerid. Intall patch and redo 3 steps.
Created attachment 39907 [details] [review] Bug 14343 Incorrect links to results pages in Receive shipment list The problem is already existing in 3.14 version and maybe previous ones.
Created attachment 39910 [details] [review] Bug 14343 Incorrect links to results pages in Receive Shipment List Numbered links have incorrect url. Links to result pages don't work in Receive Shipment List (but fortunately, Next and Previous buttons work) It's because the booksellerid is not furnished in the url. Test Plan : 1) Go to Acquisitions module, enter a bookseller name that you know you can get many page of invoices for and search for it. 2) click on Receive shipment button. 3) On bottom of the first results page, click on page number 2 link. (cf joined screencast) You'll see that the results include invoices from other booksellerid. Indeed, I suppose that you get results from all booksellerid. Intall patch and redo 3 steps. NOTE: I did not follow this test plan. I read the acqui/parcels.pl code. The template parameter numbers is assigned in a function which has no reference to booksellerid at all! Additionally, the booksellerid is set directly elsewhere. It is also strange that the booksellerid references before and after this loop do not use the numbers.booksellerid, but just booksellerid. The change from numbers.booksellerid to booksellerid is correct! Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
This applies cleanly as far back at 3.8.x
I think we removed this kind of double paging at some point after introducing the datatable, does this appear in master?
Mark write he didn't follow the test plan - please, can someone check in the GUI?
I confirm that the double paging (one from datatable and another in html) still appears in Master but the datatable one does'nt work either (next and previous buttons are disabled,show entries does not get far more than 20 results)
Hi, This patch applies on 3.16 but there is a two page gap between the result numbers and the pages actually displayed (for example, clicking on number 10 will lead to page 8). Don't know if this problem has already been reported somewhere else. Koha Team Rennes 2
Created attachment 42402 [details] [review] Bug 14343 Incorrect links to results pages in Receive Shipment List Numbered links have incorrect url. Links to result pages don't work in Receive Shipment List (but fortunately, Next and Previous buttons work) It's because the booksellerid is not furnished in the url. Test Plan : 1) Go to Acquisitions module, enter a bookseller name that you know you can get many page of invoices for and search for it. 2) click on Receive shipment button. 3) On bottom of the first results page, click on page number 2 link. (cf joined screencast) You'll see that the results include invoices from other booksellerid. Indeed, I suppose that you get results from all booksellerid. Intall patch and redo 3 steps. NOTE: I did not follow this test plan. I read the acqui/parcels.pl code. The template parameter numbers is assigned in a function which has no reference to booksellerid at all! Additionally, the booksellerid is set directly elsewhere. It is also strange that the booksellerid references before and after this loop do not use the numbers.booksellerid, but just booksellerid. The change from numbers.booksellerid to booksellerid is correct! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 42403 [details] [review] Bug 14343: Remove the DT pagination It does not make sense to have 2 paginations here. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed to master. Thanks Lyon3 Team!
Pushed to 3.20.x will be in 3.20.4