Testing something else I noticed that the damaged status is not displayed on the page for placing holds in staff. I think it would be very helpful for item level holds to be able to pick an 'undamaged' alternative item.
Created attachment 60433 [details] [review] Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds a 'Status' column to the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with Damaged, Lost, Withdrawn statuses. - Verify a new column 'Status' indicating the item's status as appropriate.
This is the first column: [% IF itemloo.not_holdable %] [% IF itemloo.not_holdable == 'damaged' %] Item damaged [% ELSIF itemloo.not_holdable == 'ageRestricted' %] Age restricted [% ELSIF itemloo.not_holdable == 'tooManyHoldsForThisRecord' %] Exceeded max holds per record [% ELSIF itemloo.not_holdable == 'tooManyReserves' %] Too many holds [% ELSIF itemloo.not_holdable == 'notReservable' %] Not holdable [% ELSIF itemloo.not_holdable == 'cannotReserveFromOtherBranches' %] Patron is from different library [% ELSIF itemloo.not_holdable == 'itemAlreadyOnHold' %] Patron already has hold for this item [% ELSE %] [% itemloo.not_holdable %] [% END %] [% END %] This is what Marc V added: <td> [% IF ( itemloo.itemlost ) %]Lost[% END %] [% IF ( itemloo.damaged ) %]Damaged[% END %] [% IF ( itemloo.withdrawn ) %]Withdrawn[% END %] </td> I think there are some underlying design issues which require further thought or at least explanation. It makes little sense to me to have two columns displaying something about the fact that it is damaged. It also is confusing that itemlost, damaged, and withdrawn would be in the same column. I didn't read the code deeper.
@Katrin: What would you like that it looks like?
Created attachment 62532 [details] [review] Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'.
(In reply to M. Tompsett from comment #2) (...) > > I think there are some underlying design issues which require further > thought or at least explanation. It makes little sense to me to have two > columns displaying something about the fact that it is damaged. It also is > confusing that itemlost, damaged, and withdrawn would be in the same column. > I didn't read the code deeper. My patch now adds a minimal information about the 'Damaged' status in the existing column 'Information'. The whole table would need some attention. I filed Bug 18475.
Created attachment 64161 [details] [review] [SIGNED-OFF] Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 66692 [details] [review] Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05. Very small enhancement, should ok for stable branches.
This patch has been pushed to 16.11.x and will be in 16.11.13.