The Saved Reports page currently shows the Creation Date of Reports. To my way of thinking, it would be much more helpful to have the Last Edit Date displayed & sortable. When I'm working with Reports I am almost always working on the same few Reports within a relatively short time period & it would be great to have an easy way of retrieving these. Along the same lines, this would also provide an easy way of identifying which Reports other librarians have been working on most recently. Cheers! Cab Vinton Plaistow Public Library
Created attachment 59985 [details] [review] Bug 14365 - Populate never used saved_sql column last_run when execute_query is called
Created attachment 59986 [details] [review] Bug 14365 - SQL Reports Last Edit Date column - Show in interface
Created attachment 59988 [details] [review] Bug 14365 - Populate never used saved_sql column last_run when execute_query is called
Created attachment 59989 [details] [review] Bug 14365 - SQL Reports Last Edit Date column - Show in interface Test Plan: 1) Apply these patches 2) Modify a saved sql report 3) Note the "Last modified" column is updated 4) Run the report 5) Note the "Last run" column is updated
Created attachment 60752 [details] [review] Bug 14365 - Change 'Last modified' to 'Last edit' for terseness
Created attachment 61060 [details] [review] [SIGNED-OFF] Bug 14365 - Populate never used saved_sql column last_run when execute_query is called Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 61061 [details] [review] [SIGNED-OFF] Bug 14365 - SQL Reports Last Edit Date column - Show in interface Test Plan: 1) Apply these patches 2) Modify a saved sql report 3) Note the "Last modified" column is updated 4) Run the report 5) Note the "Last run" column is updated Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 61062 [details] [review] [SIGNED-OFF] Bug 14365 - Change 'Last modified' to 'Last edit' for terseness Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Not blocker but it would have been good to update the prototype of the subroutine to pass a hashref instead of the list of undef... This new parameter is a bit awkward: if the id is passed, a DB field is updated. Not elegant but given the quality of the existing code it's hard to provide something better... Passing QA
Created attachment 61220 [details] [review] Bug 14365 - Populate never used saved_sql column last_run when execute_query is called Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 61221 [details] [review] Bug 14365 - SQL Reports Last Edit Date column - Show in interface Test Plan: 1) Apply these patches 2) Modify a saved sql report 3) Note the "Last modified" column is updated 4) Run the report 5) Note the "Last run" column is updated Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 61222 [details] [review] Bug 14365 - Change 'Last modified' to 'Last edit' for terseness Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05!
This won't get ported back to 16.11.x as it is an enhancement.
*** Bug 13047 has been marked as a duplicate of this bug. ***