Line 99 og Koha/NorwegianPatronDB.pm looks like this: warn "$combined_username => $combined_password"; This is clearly a leftover from development and should be deleted.
Created attachment 40233 [details] [review] Bug 14403 - Remove warn in Koha::NorwegianPatronDB Line 99 has an unconditional warn, left over from development: warn "$combined_username => $combined_password"; This patch deletes the line i question. To test: No testing needed, just have a look at the diff and see that it makes sense to delete the warn.
Created attachment 40236 [details] [review] Bug 14403 - Remove warn in Koha::NorwegianPatronDB Line 99 has an unconditional warn, left over from development: warn "$combined_username => $combined_password"; This patch deletes the line i question. To test: No testing needed, just have a look at the diff and see that it makes sense to delete the warn. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Created attachment 40259 [details] [review] Bug 14403 - Remove warn in Koha::NorwegianPatronDB Line 99 has an unconditional warn, left over from development: warn "$combined_username => $combined_password"; This patch deletes the line i question. To test: No testing needed, just have a look at the diff and see that it makes sense to delete the warn. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Patch pushed to master. Good catch Magnus!
Pushed to 3.20.x will be in 3.20.2
Pushed to 3.18.x will be in 3.18.09
Skipping for 3.16.x series, due to patch conflicts