Bug 14406 - When adding messages in patron account, only first name is shown in pull down
Summary: When adding messages in patron account, only first name is shown in pull down
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Briana Greally
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2015-06-17 15:54 UTC by Katrin Fischer
Modified: 2017-01-10 19:33 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 14406 When adding messages in patron account, only first name is shown in pull down (1.34 KB, patch)
2016-01-19 01:05 UTC, Briana Greally 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 14406 When adding messages in patron account, only first name is shown in pull down (1.49 KB, patch)
2016-01-19 16:11 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 14406 When adding messages in patron account, only first name is shown in pull down (1.51 KB, patch)
2016-01-19 17:10 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-06-17 15:54:02 UTC 
When you add a note to a patron account using the 'Add messages' link on the details tab in the staff patron account, you are shown a pull down that says:

- Other librarians
- Katrin (firstname of the patron)

I think this is not unusual and not in sync with how we label other similar note fields and features. Suggestions:

- Staff / staff client / Internal note
- OPAC / full name of the patron etc.
Comment 1 Katrin Fischer 2016-01-18 00:04:20 UTC 
... should have read: I think this _is_ unusual ... :)

Libraries have been irritated by the first name for the patron in the pull down.
Comment 2 Briana Greally 2016-01-19 01:05:29 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-01-19 16:11:40 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-19 17:10:05 UTC 
Created attachment 46912 [details] [review]
Bug 14406 When adding messages in patron account, only first name is shown in pull down

To test:

Log in to staff patron account
Go to Checkout tab
Click 'Add a new message'
Drop down box should show 'Staff - Internal Note' and 'OPAC - [Full name
of patron]'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Made a tiny change during signoff: uncapitalized "note"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jesse Weaver 2016-01-19 23:12:19 UTC 
Pushed to master, thanks for your work!

(Added a colon to the commit message for consistency's sake.)
Comment 6 Julian Maurice 2016-02-04 21:16:14 UTC 
Patch pushed to 3.22.x, will be in 3.22.3
Comment 7 Frédéric Demians 2016-02-20 08:52:30 UTC 
This patch has been pushed to 3.20.x, will be in 3.20.9.