This is where I'll put all the patches for help files for 3.20.
Created attachment 40416 [details] [review] Bug 14424: Admin Help Files for 3.20 This patch updates some of the help files for Admin areas in 3.20+ To test: * Visit * Frameworks, add field, add subfield * Column settings * Patron attributes * Circ rules * Confirm help loads up and is right
Created attachment 40418 [details] [review] Bug 14424: Tools Help Files for 3.20 This patch updates and adds help files to 3.20+ To test: * Visit batch record modification and note that there is a help file and confirm the text is right * Visit export data, import borrowers, stage marc for import, and log viewer * Confirm updated text is right
Created attachment 40422 [details] [review] [SIGNED OFF] Bug 14424: Admin Help Files for 3.20 This patch updates some of the help files for Admin areas in 3.20+ To test: * Visit * Frameworks, add field, add subfield * Column settings * Patron attributes * Circ rules * Confirm help loads up and is right Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 40423 [details] [review] [SIGNED OFF] Bug 14424: Tools Help Files for 3.20 This patch updates and adds help files to 3.20+ To test: * Visit batch record modification and note that there is a help file and confirm the text is right * Visit export data, import borrowers, stage marc for import, and log viewer * Confirm updated text is right Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 40476 [details] [review] Bug 14424: Admin Help Files for 3.20 This patch updates some of the help files for Admin areas in 3.20+ To test: * Visit * Frameworks, add field, add subfield * Column settings * Patron attributes * Circ rules * Confirm help loads up and is right Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40477 [details] [review] Bug 14424: Tools Help Files for 3.20 This patch updates and adds help files to 3.20+ To test: * Visit batch record modification and note that there is a help file and confirm the text is right * Visit export data, import borrowers, stage marc for import, and log viewer * Confirm updated text is right Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
It could worth to create a css rule like: body#help .important { color: #990000; }
(In reply to Jonathan Druart from comment #7) > It could worth to create a css rule like: > body#help .important { > color: #990000; > } +1
Patches pushed to master. Thanks Nicole!
Created attachment 40536 [details] [review] Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three
PS. also one for Tips :)
Created attachment 40537 [details] [review] Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible
Created attachment 40538 [details] [review] Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right
Created attachment 40539 [details] [review] Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help
Created attachment 40540 [details] [review] Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct
I think I might be done ... does anyone see a page I missed that updated? Nicole
Nicole, if you could fix the whitespace issues below, I'll gladly sign off. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member-flags.tt FAIL forbidden patterns forbidden pattern: tab char (line 128) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 74) forbidden pattern: tab char (line 465) forbidden pattern: tab char (line 206) forbidden pattern: tab char (line 132) forbidden pattern: tab char (line 467) forbidden pattern: tab char (line 130) forbidden pattern: tab char (line 224) forbidden pattern: tab char (line 432) forbidden pattern: tab char (line 429) forbidden pattern: tab char (line 125) forbidden pattern: tab char (line 222) forbidden pattern: tab char (line 91) forbidden pattern: tab char (line 225) forbidden pattern: tab char (line 131) forbidden pattern: tab char (line 93) forbidden pattern: tab char (line 204) forbidden pattern: tab char (line 523) forbidden pattern: tab char (line 207) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 521) forbidden pattern: tab char (line 431) forbidden pattern: tab char (line 468) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member.tt FAIL forbidden patterns forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 52) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/members/members-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 54) forbidden pattern: tab char (line 44) OK tt_valid OK valid_template And for people who don't have time to figure out the UI (like myself), you can trigger them all directly using these URLs. Make sure to change {STAFF CLIENT} to the appropriate value (e.g. http://library-admin.debiankoha.ca) {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/member-flags.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/member.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/members-home.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/cataloguing/addbiblio.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/cataloguing/addbooks.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/cataloguing/merge.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/discharge.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/moremember.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/acqui/basket.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/acqui/newordersubscription.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/circ/on-site_checkouts.pl
As per my discussion with tcohen on IRC, I'm signing off, because "we are loos[en]ing the coding guidelines for the help pages, because Nicole copy/pastes from the manual, otherwise is too much work" For future reference, Nicole, these git commands are handy in preventing whitespace issues like this: git config --global core.whitespace trailing-space,space-before-tab git config --global apply.whitespace fix Just type them once in your Koha git area, and never think about it again. :)
Created attachment 40833 [details] [review] Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40834 [details] [review] Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40835 [details] [review] Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40836 [details] [review] Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40837 [details] [review] Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40863 [details] [review] Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40864 [details] [review] Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40865 [details] [review] Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40866 [details] [review] Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40867 [details] [review] Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40868 [details] [review] Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40869 [details] [review] Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40870 [details] [review] Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40871 [details] [review] Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40872 [details] [review] Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Sorry for the flood, I forgot my signed-off-by line.
Patches pushed to master. Thanks Nicole! Chris: there ya go!
Pushed to 3.20.x will be in 3.20.2