Created attachment 40486 [details] Example screenshot of OPAC renewal message Dear Colleagues, When an item has a hold placed on it and a patron is logged into the OPAC, the OPAC only displays "Automatic renewal (x of y renewals remaining)", but does not indicate that the automatic renewal will not take place due to the fact that another patron has placed a hold on the item in question. If the logged-in patron clicks/taps on the "Renew all" link found in the upper-right corner of the "Checked out" tab, then the OPAC finally indicates that the item cannot be renewed and gives the reason why it cannot. I think that this will confuse the patron into thinking that the loan on their item will eventually be renewed automatically, when in reality, the loan will not be renewed because of the hold placed on the item. The OPAC should indicate on the "Checked out" tab that the item in question cannot, and will not, be renewal because a hold is placed on the said item. FWIW, Christopher Davis, MLS Systems & E-Services Librarian Uintah County Library
No longer valid on current master (Fixed by Bug 3083 ?)
The bug that Marc links to does not address this issue, which specifically has to do with auto-renewal. Yes, if auto-renewal is turned off and a hold is placed on an item, there's a warning to the patron. This warning does not appear when auto-renewal is on however, instead it appears to the patron as if they can continue renewing. Christopher clearly outlined this in the original bug report and screenshot and it is not fixed on master.
Created attachment 54455 [details] [review] Bug 14434: Display "On hold" in OPAC for auto renewed items This patch makes the OPAC display "On hold" instead of "Automatic renewal" when a hold is placed. Test plan: 1) Issue an item with automatic renewal. 2) Place a hold on the item. 3) Log in as patron and note that the column "Renew" says "Automatic renewal (x of y renewals remaining)." 4) Apply patch. 5) Refresh OPAC and note that now "On hold" is displayed. 6) Cancel the hold, then log in as patron again and note that now "Automatic renewal (x of y renewals remaining)" is displayed once again. Sponsored-by: Hochschule für Gesundheit (hsg), Germany
I think that "On hold" isn't clear yet. Maybe something like "Not renewable (On hold)" would be much better.
"On hold" is what is displayed for manual renewals when a hold is placed. I think it should be the same for auto renewals. Otherwise the patron might have regular items that are "on hold" and auto-renewed items that are "not renewable (on hold)". So maybe the wording should be changed/discussed in another bug? This one is just about adding the standard information that was missing.
+1 for a new bug regarding the wording
Created attachment 54512 [details] [review] [SIGNED-OFF]Bug 14434: Display "On hold" in OPAC for auto renewed items This patch makes the OPAC display "On hold" instead of "Automatic renewal" when a hold is placed. Test plan: 1) Issue an item with automatic renewal. 2) Place a hold on the item. 3) Log in as patron and note that the column "Renew" says "Automatic renewal (x of y renewals remaining)." 4) Apply patch. 5) Refresh OPAC and note that now "On hold" is displayed. 6) Cancel the hold, then log in as patron again and note that now "Automatic renewal (x of y renewals remaining)" is displayed once again. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
The test case already exists a few lines after. What you want to do is to move it before the ELSIF ISSUE.auto_renew tests, not to add another one.
Oops. Sorry about that. And now that I realized it's actually the same code for both cases, I used "Not renewable (on hold)" as Héctor suggested. I hope that's okay :)
Created attachment 54842 [details] [review] Bug 14434: Display "Not renewable (on hold)" in OPAC This patch makes the OPAC display "Not renewable (on hold)" when a hold is placed. Test plan: 1) Do not apply patch. 2) Issue an item with automatic renewal. 3) Issue an item with manual renewal. 4) Place a hold on both items. 5) Log in as patron and note that the column "Renew" says "Automatic renewal (x of y renewals remaining)" for the auto renewed item and "(On hold) for the other item. 6) Apply patch. 7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed for both items. 8) Cancel the holds, then log in as patron again and confirm that the correct renewal conditions are displayed. Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Created attachment 54843 [details] [review] Bug 14434: Display "Not renewable (on hold)" in OPAC This patch makes the OPAC display "Not renewable (on hold)" when a hold is placed. Test plan: 1) Do not apply patch. 2) Issue an item with automatic renewal. 3) Issue an item with manual renewal. 4) Place a hold on both items. 5) Log in as patron and note that the column "Renew" says "Automatic renewal (x of y renewals remaining)" for the auto renewed item and "(On hold) for the other item. 6) Apply patch. 7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed for both items. 8) Cancel the holds, then log in as patron again and confirm that the correct renewal conditions are displayed. Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Created attachment 54877 [details] [review] [SIGNED-OFF]Bug 14434: Display "Not renewable (on hold)" in OPAC This patch makes the OPAC display "Not renewable (on hold)" when a hold is placed. Test plan: 1) Do not apply patch. 2) Issue an item with automatic renewal. 3) Issue an item with manual renewal. 4) Place a hold on both items. 5) Log in as patron and note that the column "Renew" says "Automatic renewal (x of y renewals remaining)" for the auto renewed item and "(On hold) for the other item. 6) Apply patch. 7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed for both items. 8) Cancel the holds, then log in as patron again and confirm that the correct renewal conditions are displayed. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Created attachment 54915 [details] [review] Bug 14434: Display "Not renewable (on hold)" in OPAC This patch makes the OPAC display "Not renewable (on hold)" when a hold is placed. Test plan: 1) Do not apply patch. 2) Issue an item with automatic renewal. 3) Issue an item with manual renewal. 4) Place a hold on both items. 5) Log in as patron and note that the column "Renew" says "Automatic renewal (x of y renewals remaining)" for the auto renewed item and "(On hold) for the other item. 6) Apply patch. 7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed for both items. 8) Cancel the holds, then log in as patron again and confirm that the correct renewal conditions are displayed. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Holger!
Pushed in 16.05. Will be in 16.05.04.
Pushed to 3.22.x, will be in 3.22.11