Undefined value $searchmember
Created attachment 40507 [details] [review] Bug 14436 - Undefined $searchmember causing warns in C4/Utils/DataTables/Members.pm This patch sets $searchmember to an empty string to avoid warns. To test: 1) Go to Patrons (/cgi-bin/koha/members/members-home.pl) and pick any letter to 'Browse by last name' 2) Notice the warns in the error log 3) Apply patch 4) Reload page and pick a letter to browse by last name 5) Notice page still works but no warns in error log
Found another warn when using the search bar to Check out (Enter patron card number or partial name:) Use of uninitialized value $searchtype in string eq at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 79.
Created attachment 40799 [details] [review] Bug 14436: Undefined $searchtype causing warns Don't forget to apply both patches and test for the first patch too! To test this patch: 1) Use Check out tab on search bar 'enter patron card number or partial name' 2) Notice warns 3) Apply patch and reload page (ie make new search) 4) Notice page still works but no warns
Hi Aleisha, I feel these two one-liners should be squashed into one patch. What say?
(In reply to Indranil Das Gupta from comment #4) > Hi Aleisha, > > I feel these two one-liners should be squashed into one patch. What say? Not only that, but I think you fixed them in the wrong place. These are parameters set at the beginning of the function. I would correct $searchmember after line 21. -- after looking further, bug 14344 corrected the issue with the second patch. As such, I am obsoleting the second patch.
Created attachment 40926 [details] [review] Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools.
Created attachment 40931 [details] [review] Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Created attachment 40966 [details] [review] Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patch pushed to master. Thanks Aleisha!
Pushed to 3.20.x will be in 3.20.2