Another side effect of this patches is that item search gets broken (3.18.x and up seems to be affected), because we have at least two templates like this: - catalogue/itemsearch.json.tt - catalogue/itemsearch.csv.tt Originally reported by Jacek Ablewicz
Created attachment 40565 [details] [review] bug 14450 - itemsearch no longer working To test: Click Advanced search in staff client Click the link for "Go to Item Search" at the top of the page Do a search, you should get results. Try some combinations and make sure it works like it should.
Created attachment 40566 [details] [review] bug 14450 - itemsearch no longer working To test: Click Advanced search in staff client Click the link for "Go to Item Search" at the top of the page Do a search, you should get results. Try some combinations and make sure it works like it should. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40567 [details] [review] [SIGNED-OFF] Bug 14450 - itemsearch no longer working To test: Click Advanced search in staff client Click the link for "Go to Item Search" at the top of the page Do a search, you should get results. Try some combinations and make sure it works like it should. Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
(In reply to Jacek Ablewicz from comment #3) > Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Hehe, too slow Jacek ;)
Created attachment 40568 [details] [review] Bug 14450 - itemsearch no longer working To test: Click Advanced search in staff client Click the link for "Go to Item Search" at the top of the page Do a search, you should get results. Try some combinations and make sure it works like it should. Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40570 [details] [review] [PASSED QA] Bug 14450 - itemsearch no longer working To test: Click Advanced search in staff client Click the link for "Go to Item Search" at the top of the page Do a search, you should get results. Try some combinations and make sure it works like it should. Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Patch pushed to master. Thanks Liz!
Pushed to 3.20.x will be in 3.20.2
Pushed to 3.18.x, will be in 3.18.09
*** Bug 14679 has been marked as a duplicate of this bug. ***