To recreate, go to any patron's page and click Change Password member-password.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-password.pl line 105 member-password.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-password.pl line 105
Created attachment 40748 [details] Bug 14484: Silences warns triggered when changing patron password Use of uninitialized value $roadtype To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly
I'd suggest my $roadtype = C4::Koha::GetAuthorisedValueByCode( 'ROADTYPE', $bor->{streettype} ) // '';
Created attachment 41095 [details] [review] Bug 14484: Jonathan Druart's fix To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly
I get an error when I try to apply the patch: > Applying: Bug 14484: Jonathan Druart's fix > fatal: sha1 information is lacking or useless (members/member-password.pl). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 14484: Jonathan Druart's fix It looks like the second patch modifies the first one, so 1) the first patch should not be obsoleted OR 2) the second one should be done against master without the first in between the second being the better option.
Created attachment 41454 [details] [review] Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly
Sorry, but the new attachment looks the same as the one before (and I get the same error)
Created attachment 41487 [details] [review] Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly
Created attachment 41495 [details] [review] Bug 14484: warns when changing patron pw Warning disappears, code looks good. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 41603 [details] [review] Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patch pushed to master. Thanks Aleisha!