When using the script export_borrowers.pl the patron attributes are not exposed to the CSV. The idea is to have a field called patron_attributes that exposes all the extended attributes.
Created attachment 40802 [details] [review] Export borrowers script Sorry I couldn't create a patch for this. Can someone please do that?
There is no change with your file and the one in master.
Created attachment 41340 [details] [review] export_borrowers.pl changed to support patron attributes
Created attachment 41341 [details] [review] export_borrowers.pl changed to support patron attributes Test plan: - Use export_borrowers.pl to export all patron and all fields - The patrons extended attributes are not exported - Apply the patch - Use export_borrowers.pl with the no fields specified or with the field patron_attributes - The patrons extended attributes will be exported in one column Create by: Vitor Fernandes <vfernandes@keep.pt> Sponsored by: KEEP SOLUTIONS
Is it ready to test? Don't forget to provide a test plan.
Jonathan, Yes, is ready to test. You can check the test plan on the patch commit.
(In reply to Vitor Fernandes from comment #6) > You can check the test plan on the patch commit. Yes sorry, it's on the bug report but not on the patch! Thanks.
Vitor, your patch uses GetBorrowerAttributes which has been moved from C4::Member to C4::Members::Attributes. Could you add this to export_borrowers.pl? use C4::Members::Attributes qw(GetBorrowerAttributes); And add the test plan to the patch itself as suggested by Johnatan?
Created attachment 76926 [details] [review] Bug 14493: export_borrowers.pl - Export patron attributes Tweaked Vitor's original patch to accomodate changes to the file. --- export_borrowers.pl changed to support patron attributes Test plan: - Use export_borrowers.pl to export all patron and all fields - The patrons extended attributes are not exported - Apply the patch - Use export_borrowers.pl with the no fields specified or with the field patron_attributes - The patrons extended attributes will be exported in one column Create by: Vitor Fernandes <vfernandes@keep.pt> Sponsored by: KEEP SOLUTIONS Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Created attachment 89574 [details] [review] Bug 14493: export_borrowers.pl - Export patron attributes Tweaked Vitor's original patch to accomodate changes to the file. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
We try to test today : this patch doesn't apply on a sandbox (Biblibre n°1)
Bug 14493 - export_borrowers.pl - Export patron attributes 41341 - export_borrowers.pl changed to support patron attributes 89574 - Bug 14493: export_borrowers.pl - Export patron attributes Apply? [(y)es, (n)o, (i)nteractive] y Applying: export_borrowers.pl changed to support patron attributes Using index info to reconstruct a base tree... M misc/export_borrowers.pl Falling back to patching base and 3-way merge... Auto-merging misc/export_borrowers.pl CONFLICT (content): Merge conflict in misc/export_borrowers.pl Failed to merge in the changes. Patch failed at 0001 export_borrowers.pl changed to support patron attributes
Would be great to see this one rescued!