Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds
Created attachment 40805 [details] [review] Bug 14496 : Improving opac-detail.pl performances Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds
nice job Julian
I believe the non-XSLT detail display is deprecated or scheduled to be deprecated, no?
There were some performance issues raised about the XSLT view - I think we haven't gotten to officially deprecate it afaik. So this should be fine. Might also be worth taking a look how big the performance difference is between both views.
I've made some measures without XSLT and with the Default one. My results were : On opac-detail with XSLT by Default is ~ 4 % longer than without any. On opac-search with XSLT by Default is ~ 2,5% longer than without any.
Thx Julian! - Do you happen to have some times for the page loads to compare too?
Here are my results (in seconds) : Opac-details ------------ No XSLT | Default XSLT 11,222 | 12,217 11,836 | 11,334 11,246 | 11,611 11,508 | 12,236 11,288 | 12,055 average No XSLT --> Default XSLT 11,42s --> 11,89s (+470ms) Opac-search ------------ No XSLT | Default XSLT 3,092 | 3,153 3,322 | 3,248 3,088 | 3,405 3,172 | 3,183 3,119 | 3,205 average No XSLT --> Default XSLT 3,15s --> 3,24s (+90ms)
Created attachment 40890 [details] [review] [Signed-off] Bug 14496 : Improving opac-detail.pl performances Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds I compared the display of some records in XSLT view with and without patch, was the same (as expected). Signed-off-by: Marc Véron <veron@veron.ch>
(In reply to David Cook from comment #3) > I believe the non-XSLT detail display is deprecated or scheduled to be > deprecated, no? Yes, and this helps the XSLT view a little bit further.
Created attachment 40914 [details] [review] Bug 14496 : Improving opac-detail.pl performances Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds I compared the display of some records in XSLT view with and without patch, was the same (as expected). Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> On a slower server, I saw a time save of 0.0274 to 0.0908 seconds (with XSLT).
Patch pushed to master. Nice improvement Julian!
Pushed to 3.20.x will be in 3.20.2
Hi Julian, We weren't quite done here - still other versions this patch might go into. :) (So I'm reopening it) Liz
Hi Liz, Ok, my bad :) But before changing its status to "RESOLVED", it was in "PUSHED TO STABLE". It may be not necessary changing it to "NEED SIGNOFF", "PUSHED TO STABLE" should be fine ? Julian F.
Hi, I don't have the permissions to take it back to that status, but Katrin does! Thanks Katrin! Cheers, Liz
The problem is that you have to stick to the workflow so from signed off - signed off - passed qa - pushd to stable... :)
Pushed to 3.18.x will be in 3.18.09
Pushed to 3.16.x, will be in 3.16.13