When subscribing to a RSS feed from the OPAC result list, no results are shown for it. Tested with a dynamic bookmark in Firefox. Reason might be the use of |html instead of |url/uri as TT filter. Tested in 3.18.8 so far, but I think other versions are probably also affected.
Confirmed on current master.
...and 3.20.1.
I have this in the OPAC error log: [Mon Jul 13 13:07:02.090923 2015] [cgi:error] [pid 4481] [client 127.0.0.1:55102] AH01215: [Mon Jul 13 13:07:02 2015] opac-search.pl: Use of uninitialized value in split at /home/magnus/scripts/kohaclone/opac/opac-search.pl line 501. [Mon Jul 13 13:07:02.096514 2015] [cgi:error] [pid 4481] [client 127.0.0.1:55102] AH01215: [Mon Jul 13 13:07:02 2015] opac-search.pl: WARNING: query problem with ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /home/magnus/scripts/kohaclone/C4/Search.pm line 379. Not sure what is relevant.
Introduced by 14418. Since query_cgi contains something like "idx=kw&q=42", we should not use the uri filter.
Created attachment 40974 [details] [review] Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted.
Created attachment 40978 [details] [review] Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 41047 [details] [review] [PASSED QA] Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.09
Doesn't seem to effect translations pushed to 3.20.x will be in 3.20.2
Pushed to 3.16.x, will be in 3.16.13