From reading the code it looks like CalcFine returns 4 values, while only 3 are documented (missing:chargeable_units). There is also a mismatch in names between the first and second paragraphs ($daycounttotal vs. $unitcount)
Created attachment 46831 [details] [review] Bug 14538: editing perl doc for CalcFine To Test: Read perldoc C4/Overdues.pm Confirm that it says CalcFine returns four values and that rest of the documentation is correct
Created attachment 46907 [details] [review] Bug 14538: editing perl doc for CalcFine To Test: Read perldoc C4/Overdues.pm Confirm that it says CalcFine returns four values and that rest of the documentation is correct NOTE: only a little visual ugliness, but definitely an improvement. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46909 [details] [review] Bug 14538: editing perl doc for CalcFine To Test: Read perldoc C4/Overdues.pm Confirm that it says CalcFine returns four values and that rest of the documentation is correct NOTE: only a little visual ugliness, but definitely an improvement. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master, thanks for your work!
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.