Single quotes in common language (not in programming) are usually ', but there is also the form ’. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space.
Created attachment 41032 [details] [review] Bug 14542 - Transliterate rule for all single quote forms Single quotes in common language (not in programming) are usually ', but there is also the form known as ’ in HTML. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. Test plan : (I'll use the code ’ instead of the unicode character) - Without the patch - Create a record with title : L’avion d’argile - Index this record - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You do not find the record - Apply patch - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You find the record - Search for "L avion d argile" => You find the record
Created attachment 44753 [details] [review] Bug 14542 - Transliterate rule for all single quote forms Single quotes in common language (not in programming) are usually ', but there is also the form known as ’ in HTML. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. Test plan : (I'll use the code ’ instead of the unicode character) - Without the patch - Create a record with title : L’avion d’argile - Index this record - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You do not find the record - Apply patch - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You find the record - Search for "L avion d argile" => You find the record Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Created attachment 44757 [details] [review] Bug 14542 - Transliterate rule for all single quote forms Single quotes in common language (not in programming) are usually ', but there is also the form known as ’ in HTML. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. Test plan : (I'll use the code ’ instead of the unicode character) - Without the patch - Create a record with title : L’avion d’argile - Index this record - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You do not find the record - Apply patch - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You find the record - Search for "L avion d argile" => You find the record Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Can be considered as a bugfix.
Patch pushed to master. Good catch Frido!
This patch has been pushed to 3.20.x, will be in 3.20.6.
Pushed to 3.18.13, and released.