Bug 14555 - Warns in opac-search.pl
Summary: Warns in opac-search.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-17 04:11 UTC by Aleisha Amohia
Modified: 2017-06-14 22:11 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14555: Warns in opac-search.pl (934 bytes, patch)
2015-09-21 11:18 UTC, Martin Stenberg
Details | Diff | Splinter Review
Bug 14555: Warns in opac-search.pl (1.18 KB, patch)
2016-01-01 13:12 UTC, Martin Stenberg
Details | Diff | Splinter Review
Bug 14555: Warns in opac-search.pl (1.24 KB, patch)
2016-01-06 00:44 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 14555: Warns in opac-search.pl (1.34 KB, patch)
2016-01-07 16:01 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2015-07-17 04:11:34 UTC
opac-search.pl: Use of uninitialized value in split at /home/vagrant/kohaclone/opac/opac-search.pl line 500

To recreate, scroll to the bottom of the main page on OPAC (opac-main.pl)
Choose any group on the drop-down menu under 'New titles'
Notice warn
Comment 1 Aleisha Amohia 2015-07-21 20:50:15 UTC
The 'Childrens Fiction' option under this menu also triggers two other warns:

opac-detail.pl: Use of uninitialized value $isbn in string ne at /home/vagrant/kohaclone/C4/Biblio.pm line 1700
opac-detail.pl: Use of uninitialized value $isbn in string ne at /home/vagrant/kohaclone/C4/Biblio.pm line 1700
Comment 2 Martin Stenberg 2015-08-31 10:47:34 UTC
Can no longer reproduce. Perhaps already fixed?
Comment 3 Aleisha Amohia 2015-09-01 03:54:25 UTC
(In reply to Martin Stenberg from comment #2)
> Can no longer reproduce. Perhaps already fixed?

I still get the uninitialized value in split warn, but not the extra warns triggered by the 'Childrens Fiction' option.
Comment 4 Martin Stenberg 2015-09-21 11:18:44 UTC Comment hidden (obsolete)
Comment 5 Frédéric Demians 2015-11-11 12:45:35 UTC
A complete test plan, working on master, should be proposed.
Comment 6 Jonathan Druart 2015-12-28 16:02:13 UTC
Please provide a more detailed test plan.
Comment 7 Martin Stenberg 2016-01-01 13:12:20 UTC Comment hidden (obsolete)
Comment 8 Aleisha Amohia 2016-01-06 00:44:04 UTC Comment hidden (obsolete)
Comment 9 Bernardo Gonzalez Kriegel 2016-01-06 11:12:42 UTC
Hi Aleisha, switch this to signed-off :)
Comment 10 Jonathan Druart 2016-01-07 15:57:53 UTC
I don't get the warn in the logs.
Comment 11 Jonathan Druart 2016-01-07 15:58:44 UTC
Ok got it, the test plan is incomplete.
Comment 12 Jonathan Druart 2016-01-07 16:01:39 UTC
Created attachment 46405 [details] [review]
Bug 14555: Warns in opac-search.pl

Avoid use of uninitialized value in split

== Test plan ==
1. Go to opac advanced search
2. Click "Search" without any search query
3. Log file will show "Use of uninitialized value in split at ..."
4. Apply this patch
5. Repeat step 1 and 2
6. Log file should no longer show "Use of uninitialized value in split at ..."

Sponsored-by: Regionbibliotek Halland / County library of Halland
Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
At step 2 you have to check a criteria
Comment 13 Brendan Gallagher 2016-01-27 04:37:55 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!
Comment 14 Julian Maurice 2016-01-29 14:04:41 UTC
Patch pushed to 3.22.x, will be in 3.22.3
Comment 15 Frédéric Demians 2016-02-12 06:39:49 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.