opac-search.pl: Use of uninitialized value in split at /home/vagrant/kohaclone/opac/opac-search.pl line 500 To recreate, scroll to the bottom of the main page on OPAC (opac-main.pl) Choose any group on the drop-down menu under 'New titles' Notice warn
The 'Childrens Fiction' option under this menu also triggers two other warns: opac-detail.pl: Use of uninitialized value $isbn in string ne at /home/vagrant/kohaclone/C4/Biblio.pm line 1700 opac-detail.pl: Use of uninitialized value $isbn in string ne at /home/vagrant/kohaclone/C4/Biblio.pm line 1700
Can no longer reproduce. Perhaps already fixed?
(In reply to Martin Stenberg from comment #2) > Can no longer reproduce. Perhaps already fixed? I still get the uninitialized value in split warn, but not the extra warns triggered by the 'Childrens Fiction' option.
Created attachment 42718 [details] [review] Bug 14555: Warns in opac-search.pl Avoid use of uninitialized value in split Sponsored-by: Regionbibliotek Halland / County library of Halland
A complete test plan, working on master, should be proposed.
Please provide a more detailed test plan.
Created attachment 46173 [details] [review] Bug 14555: Warns in opac-search.pl Avoid use of uninitialized value in split == Test plan == 1. Go to opac advanced search 2. Click "Search" without any search query 3. Log file will show "Use of uninitialized value in split at ..." 4. Apply this patch 5. Repeat step 1 and 2 6. Log file should no longer show "Use of uninitialized value in split at ..." Sponsored-by: Regionbibliotek Halland / County library of Halland
Created attachment 46294 [details] [review] Bug 14555: Warns in opac-search.pl Avoid use of uninitialized value in split == Test plan == 1. Go to opac advanced search 2. Click "Search" without any search query 3. Log file will show "Use of uninitialized value in split at ..." 4. Apply this patch 5. Repeat step 1 and 2 6. Log file should no longer show "Use of uninitialized value in split at ..." Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Hi Aleisha, switch this to signed-off :)
I don't get the warn in the logs.
Ok got it, the test plan is incomplete.
Created attachment 46405 [details] [review] Bug 14555: Warns in opac-search.pl Avoid use of uninitialized value in split == Test plan == 1. Go to opac advanced search 2. Click "Search" without any search query 3. Log file will show "Use of uninitialized value in split at ..." 4. Apply this patch 5. Repeat step 1 and 2 6. Log file should no longer show "Use of uninitialized value in split at ..." Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> At step 2 you have to check a criteria
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.3
This patch has been pushed to 3.20.x, will be in 3.20.9.