Some librarians have expressed that it would be helpful if the holds tab displayed the count of holds for a record.
Created attachment 41058 [details] Example illustration of holds tab with count
Created attachment 41060 [details] [review] Bug 14557 - Clean up biblio-view-menu.inc
Created attachment 41061 [details] [review] Bug 14557 - Add holds count to holds tab Some librarians have expressed that it would be helpful if the holds tab displayed the count of holds for a record. Test Plan: 1) Apply this patch 2) Note the Holds tab for a record now displays the number of holds for that record
I'm not sure if this is anything to do with your patches, but after applying (fixed a merge conflict in biblio-view-menu.inc but otherwise fine) and attempting to go on to a record, i got these errors: Template process failed: plugin error - Can't locate Koha/Holds.pm in @INC (@INC contains: /home/vagrant/kohaclone /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/Koha/Template/Plugin/Biblio.pm line 25. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/Koha/Template/Plugin/Biblio.pm line 25. Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206.
Created attachment 41239 [details] [review] [SIGNED-OFF] Bug 14557 - Clean up biblio-view-menu.inc Signed-off-by: Jason Robb <jrobb@sekls.org>
Created attachment 41240 [details] [review] [SIGNED-OFF] Bug 14557 - Add holds count to holds tab Some librarians have expressed that it would be helpful if the holds tab displayed the count of holds for a record. Test Plan: 1) Apply this patch 2) Note the Holds tab for a record now displays the number of holds for that record Signed-off-by: Jason Robb <jrobb@sekls.org>
I am not a fan of using template plugins for this kind of usage, but I don't see another good and easy way to do this job. Marked as Passed QA.
Created attachment 41369 [details] [review] Bug 14557 - Clean up biblio-view-menu.inc Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41370 [details] [review] Bug 14557 - Add holds count to holds tab Some librarians have expressed that it would be helpful if the holds tab displayed the count of holds for a record. Test Plan: 1) Apply this patch 2) Note the Holds tab for a record now displays the number of holds for that record Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed to master. Thanks Kyle!