Due to the fact that the if statement wrapping the single-patron search does not check that a cardnumber was passed, svc/members/search will attempt to search for a patron with an empty cardnumber. This should normally fail, but if such a patron exists (a possibility after importing/migrating) it will always succeed and prevent normal searching.
What kind of searches did you try? I have a patron with cardnumber="", search by letter (browse by name), and different filter combinations work here.
Ah, on closer inspection, this is fixed by commit 481479fe627dcbabb3ef66df0724cc3fe75b110c: "Bug 12648: Fix conflict with bug 12833", which just needs to be backported to 3.18.
Created attachment 41436 [details] [review] Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string
Can't reproduce on 3.18.9. I do a search for 't', then filter the results by search type or category. One of the patrons has an empty card number. Works for me. Anything else I should try?
This error only occurs when you don't click on a first letter.
Created attachment 43292 [details] [review] Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) Works as expected This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 43568 [details] [review] [PASSED QA] Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to 3.18.x will be in 3.18.12.