C4::Calendar::insert_single_holiday() forces a value on (id) an AUTO_INCREMENT column, during an INSERT my $insertHoliday = $dbh->prepare("insert into special_holidays (id,branchcode,day,month,year,isexception,title,description) values ('', ?,?,?,?,?,?,?)");
Created attachment 64498 [details] [review] Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT Removing all the id from the columns on the inserts and removing the parameter '' of the values for the id. Test plan: 1) Go to tools -> calendar 2) Add a Holiday only on this day. 3) Add a Holiday repeated every same day of the week. 4) Add a Holiday repeated yearly on the same date. 5) Add a Holidays on a range. 6) Add a Holidays repeated yearly on a range. 7) You should have the five calendars displayed.
Created attachment 64551 [details] [review] Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT Removing all the id from the columns on the inserts and removing the parameter '' of the values for the id. Test plan: 1) Go to tools -> calendar 2) Add a Holiday only on this day. 3) Add a Holiday repeated every same day of the week. 4) Add a Holiday repeated yearly on the same date. 5) Add a Holidays on a range. 6) Add a Holidays repeated yearly on a range. 7) You should have the five calendars displayed. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works as directed. Passes QA Tools and Holidays.t
Hmm Author: Your Full Name <your_email> Reading this report, it seems that Rodrigo is the author. If so, Rodrigo, please adjust your settings for git/git-bz in the future.
Created attachment 64576 [details] [review] Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT Removing all the id from the columns on the inserts and removing the parameter '' of the values for the id. Test plan: 1) Go to tools -> calendar 2) Add a Holiday only on this day. 3) Add a Holiday repeated every same day of the week. 4) Add a Holiday repeated yearly on the same date. 5) Add a Holidays on a range. 6) Add a Holidays repeated yearly on a range. 7) You should have the five calendars displayed. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.02
This patch has been pushed to 16.11.x and will be in 16.11.10.
Pushed to 16.05.x, for 16.05.15 release