If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. How can it be disabled ?
This seems like a revival of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8080
When using private navigation in Firefox : In loggin form the loggin is not filled-in automatically and the password is filled-in automatically after choosing a loggin. Then in add patron form, the problem does not occurs. Also, in normal navigation, it is the same behavior if I have more than one loggin registred. The problem seems to be a Firefox behaviour, independently from "autocomplete=off".
I think this could be quite problematic and we should fix it: To test: - Log into Koha, allow the browser to save the password. - Create a new patron. - Verify that your saved password and username have been added to the form.
Hm, http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name
It seems like this is a known problem, but I haven't found a really good fix yet. One way I found to 'fix' it is adding additional hidden input fields of the password type to the form. As the stackoverflow entry mentions, 3+ password fields on a page keep Firefox from filling them in.
I've found using a disabled input between loggin and password disables autocompletion
Created attachment 45099 [details] [review] Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form
Created attachment 45125 [details] [review] Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 45146 [details] [review] Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> This is not elegant but it works. Note that the problem does not exist with Chromium
Pushed to master! Thanks Frido!
Patch pushed to 3.22.x, will be in 3.22.1
This patch has been pushed to 3.20.x, will be in 3.20.7.
*** Bug 14236 has been marked as a duplicate of this bug. ***
*** Bug 14430 has been marked as a duplicate of this bug. ***