Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 204 Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 208 Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 211 Use of uninitialized value $canReserve in hash element at /home/vagrant/kohaclone/reserve/request.pl line 216
Created attachment 41308 [details] [review] Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works
Created attachment 41912 [details] [review] Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Warns disappear; note that the display of the error message is still ugly.
Created attachment 41990 [details] [review] Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Warns disappear; note that the display of the error message is still ugly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patch pushed to master. Thanks Aleisha!
Patch pushed to 3.18.x, will be in 3.18.11
Pushed to 3.20.x will be in 3.20.4