The cataloguing plugin stocknumberAV is no longer working on master. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers
Created attachment 41420 [details] [review] Bug 14660: Fix stocknumberAV.pl catalguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown
Created attachment 41421 [details] [review] Bug 14660: Fix stocknumberam123.pl catalguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown
Created attachment 41422 [details] [review] Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown
Created attachment 41423 [details] [review] Bug 14660: Fix stocknumberam123.pl cataloguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown
Created attachment 41426 [details] [review] Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 41427 [details] [review] Bug 14660: Fix stocknumberam123.pl cataloguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
git bisect blames the following commit commit ff5996d65e4788e20d1c113ec70e80d0fd0710af Bug 10480: Use the framework plugin object in cataloguing This patch implements the use of Koha::FrameworkPlugin in Cataloguing, Authorities, Acquisition, Serials and Tools.
% grep -Hl output_ `grep -RL 'C4::Output' cataloguing/value_builder` cataloguing/value_builder/callnumber.pl cataloguing/value_builder/unimarc_field_010.pl cataloguing/value_builder/stocknumberAV.pl cataloguing/value_builder/stocknumberam123.pl cataloguing/value_builder/callnumber-KU.pl Some others exist.
Created attachment 41651 [details] [review] Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41652 [details] [review] Bug 14660: Fix stocknumberam123.pl cataloguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41653 [details] [review] Bug 14660: Fix 3 other cataloguing plugins These 3 should use C4::Output not to explode. Test plan: Link the plugins with the correct fields They should not log an error when calling them Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #11) > Created attachment 41653 [details] [review] [review] > Bug 14660: Fix 3 other cataloguing plugins > > These 3 should use C4::Output not to explode. > > Test plan: > Link the plugins with the correct fields > They should not log an error when calling them > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I have not tested the behavior of the plugins, but they raised an error in the log. With this patch, they don't.
Increasing the severity to major.
Should be backported to 3.20.x
Patches pushed to master. Thanks Katrina and Jonathan!
Pushed to 3.20.x will be in 3.20.3