Created attachment 41680 [details] [review] Bug 14696: useless use of String::Random in catalogue/search.pl Bug 10404 adds the use of String::Random to catalogue/search.pl but bug 11369 removes it without removing the import line. Test plan: git grep String::Random catalogue/search.pl should not return anything
Created attachment 41699 [details] [review] Looks like there is no dependencies to that module. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 42186 [details] [review] [PASSED QA] Bug 14696: useless use of String::Random in catalogue/search.pl Bug 10404 adds the use of String::Random to catalogue/search.pl but bug 11369 removes it without removing the import line. Test plan: git grep String::Random catalogue/search.pl should not return anything Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
It looks like this had been added as part of 762c3304 (Bug 10404 - add previous/next browsing to staff client), but the code has since changed and I couldn't spot a regression.
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.11.