This will have a CSS class for easy hiding.
Maybe we could also use the columns configuration for the table on this page?
Created attachment 47834 [details] [review] Bug 14753 - Show accession date on checkin This patch adds the dateaccessioned column fro an item to the display on returns.pl. The column is added with a CSS class for easy selection. To test: Check in some items Note date accessioned is not shown Apply patch Refresh page Check in some items See the added column 'Date acquired'
Created attachment 47835 [details] [review] Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins
Created attachment 47836 [details] [review] Bug 14753 - Show accession date on checkin This patch adds the dateaccessioned column fro an item to the display on returns.pl. The column is added with a CSS class for easy selection. To test: Check in some items Note date accessioned is not shown Apply patch Refresh page Check in some items See the added column 'Date acquired' Sponsored by: North Central Regional Library (ncrl.org)
Created attachment 47837 [details] [review] Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins Sponsored by: North Central Regional Library (ncrl.org)
Hi Nick, There is a stray i in returns.tt line 10 <title>Koha › Circulation › Check in [% title %]</title>i
Created attachment 48403 [details] [review] Bug 14753 - Show accession date on checkin This patch adds the dateaccessioned column fro an item to the display on returns.pl. The column is added with a CSS class for easy selection. To test: Check in some items Note date accessioned is not shown Apply patch Refresh page Check in some items See the added column 'Date acquired' Sponsored by: North Central Regional Library (ncrl.org)
Created attachment 48404 [details] [review] Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins Sponsored by: North Central Regional Library (ncrl.org)
(In reply to Marc Véron from comment #6) > There is a stray i in returns.tt line 10 Thanks Marc - fixed and rebased
Hi Nick, I tested, the 'Show/hide columns' button does not appear and I have a JavaScript error (browser cache cleared): Zeitstempel: 26.02.2016 16:35:06 Fehler: SyntaxError: expected expression, got keyword 'var' Quelldatei: http://10.0.0.62:8080/cgi-bin/koha/circ/returns.pl Zeile: 411, Spalte: 4 Quelltext: var returns_table = KohaTable("#checkedintable", {
Created attachment 48405 [details] [review] Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins Sponsored by: North Central Regional Library (ncrl.org)
Created attachment 48407 [details] [review] Bug 14753 - Show accession date on checkin This patch adds the dateaccessioned column fro an item to the display on returns.pl. The column is added with a CSS class for easy selection. To test: Check in some items Note date accessioned is not shown Apply patch Refresh page Check in some items See the added column 'Date acquired' Sponsored by: North Central Regional Library (ncrl.org) Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 48408 [details] [review] Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins Sponsored by: North Central Regional Library (ncrl.org) Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 48489 [details] [review] Bug 14753 - Show accession date on checkin This patch adds the dateaccessioned column fro an item to the display on returns.pl. The column is added with a CSS class for easy selection. To test: Check in some items Note date accessioned is not shown Apply patch Refresh page Check in some items See the added column 'Date acquired' Sponsored by: North Central Regional Library (ncrl.org) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48490 [details] [review] Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins Sponsored by: North Central Regional Library (ncrl.org) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48491 [details] [review] Bug 14753: Add the "page" parameter in the yml file checkedintable is on the returns page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48492 [details] [review] Bug 14753: Use the KohaDates plugin to display dates Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48493 [details] [review] Bug 14753: Improve the table display - thead should contain a tr - use a correct dom for the table Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48516 [details] [review] Bug 14753: Improve the table display - thead should contain a tr - use a correct dom for the table Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks