We used to be able to search by username when doing patron searching and that availability is gone. I think this happened with the new patron search form in ajax.
Same on current master, I can not search after username (userid). Switching version from 1.18 to master (hope that is OK).
Created attachment 42420 [details] [review] Bug 14782 - Add possibility to search patrons using the username (userid) This patch makes it possible to search for users using the username (userid / login name). To test: - Apply patch - Do searches from Home > Patrons - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left - Make sure that other searches behave as before
Created attachment 42454 [details] [review] Bug 14782 - Add possibility to search patrons using the username (userid) This patch makes it possible to search for users using the username (userid / login name). To test: - Apply patch - Do searches from Home > Patrons - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left - Make sure that other searches behave as before Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
I am in favor of this change, but it would be good to have a test to back it up!
Created attachment 42498 [details] [review] Bug 14782: Add tests Run: perl t/db_dependent/Utils/Datatables_Members.t
Created attachment 42499 [details] [review] [PASSED QA] Bug 14782 - Add possibility to search patrons using the username (userid) This patch makes it possible to search for users using the username (userid / login name). To test: - Apply patch - Do searches from Home > Patrons - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left - Make sure that other searches behave as before Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Tried my hand at writing some... hopefully they are useful.
Patches pushed to master. Thanks Katrina and Marc!
Pushed to 3.20.x will be in 3.20.4
Pushed to 3.18.x will be in 3.18.11