Move opac-topissues.pl code into C4::Circulation
Created attachment 42406 [details] [review] Bug 14788: Move opac-topissues.pl code into C4::Circulation
Hi Julian, With the patch, the checkouts on the result table do no longer sort numerically but alpabetically, something like: 1 -14 - 2- 26- 89 instead of 1 -2 -14 -26- 89
Hi Marc, I have the same behaviour on master, I don't think the patch is responsible for that.
Created a new bug: Bug 14940 Switching back to Needs signoff
Created attachment 43051 [details] [review] Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc Véron <veron@veron.ch>
Julian, please provide tests.
Created attachment 43115 [details] [review] Bug 14788: Add unit tests for GetTopIssues
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
Created attachment 43184 [details] [review] Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 43185 [details] [review] Bug 14788: Add unit tests for GetTopIssues
Patches rebased on master. Minor conflict resolved, switching back to Signed Off
Created attachment 43730 [details] [review] [PASSED QA] Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 43731 [details] [review] [PASSED QA] Bug 14788: Add unit tests for GetTopIssues Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I think this is an improvement over the current code, but needs to be pushed together with bug 11139 that will actually make it work nicely :) If you add multiple values in AdvancedSearchTypes with only this patch, it doesn't work quite right yet - but tested with 11139 things look alright.
Patches pushed to master. Good job Julian!
]% prove t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/GetTopIssues.t .. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at C4/Items.pm line 2196. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at C4/Items.pm line 2196. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Circulation/GetTopIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/14 subtests Test Summary Report ------------------- t/db_dependent/Circulation/GetTopIssues.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 14 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.02 csys = 1.44 CPU) Result: FAIL
Ok... The AI on my biblio and biblioitems tables differ. I don't really know why...