Created attachment 52427 [details] [review] Bug 14790 - Add OPAC view link to serials toolbar Test Plan: 1) Apply this patch 2) Go to subscription-detail.pl for a serial 3) Note the new OPAC view button 4) Click the button, it should open the corrosponding the OPAC detail page for that record in a new tab.
Created attachment 52428 [details] [review] Bug 14790 - Add Opac view link to search results Test Plan: 1) Apply this patch 2) Perform a staff catalog search 3) Note the new "OPAC view" link 4) Click the link, it should open a new tab to the OPAC details for that record.
Created attachment 52429 [details] [review] Bug 14790 - Add OPAC view link to catalog toolbar Test Plan: 1) Apply this patch 2) Browse to the details page for a record 3) Note the new OPAC view button on the toolbar 4) Click the link, it should open a new tab with the corrosponding record to the opac details page for it
Created attachment 52430 [details] [review] Bug 14790 - Add OPAC view link to items editor Test Plan: 1) Apply this patch 2) Find a record and open the items editor for it 3) Click the "Actions" button for an item 4) Choose the option "OPAC view" 5) A new browser tab should open to the OPAC details page for the record whose items you are editing.
Created attachment 52434 [details] [review] Bug 14790 - Add Opac view link to search results Test Plan: 1) Apply this patch 2) Perform a staff catalog search 3) Note the new "OPAC view" link 4) Click the link, it should open a new tab to the OPAC details for that record.
Created attachment 52435 [details] [review] Bug 14790 - Add OPAC view link to items editor Test Plan: 1) Apply this patch 2) Find a record and open the items editor for it 3) Click the "Actions" button for an item 4) Choose the option "OPAC view" 5) A new browser tab should open to the OPAC details page for the record whose items you are editing.
Created attachment 52436 [details] [review] Bug 14790 - Add OPAC view link to Serials detail Test Plan: 1) Apply this patch 2) Browse to subscription-detail.pl for a given serial 3) Note the new "OPAC view" link 4) Click the link, a new tab should open up showing the record details for that record in the OPAC
Created attachment 52437 [details] [review] [SIGNED-OFF] Bug 14790 - Add Opac view link to search results Test Plan: 1) Apply this patch 2) Perform a staff catalog search 3) Note the new "OPAC view" link 4) Click the link, it should open a new tab to the OPAC details for that record. This works fine except that it doesn't open in a new tab. I don't think it's the fault of the patch, but of browser.js messing with links again (See Bug 11937). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 52438 [details] [review] [SIGNED-OFF] Bug 14790 - Add OPAC view link to items editor Test Plan: 1) Apply this patch 2) Find a record and open the items editor for it 3) Click the "Actions" button for an item 4) Choose the option "OPAC view" 5) A new browser tab should open to the OPAC details page for the record whose items you are editing. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 52439 [details] [review] [SIGNED-OFF] Bug 14790 - Add OPAC view link to Serials detail Test Plan: 1) Apply this patch 2) Browse to subscription-detail.pl for a given serial 3) Note the new "OPAC view" link 4) Click the link, a new tab should open up showing the record details for that record in the OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org>
In catalogue/detail.pl, we already have a "OPAC view" link (only for non-XSLT views (?)). It tests if OPACBaseURL exists. It may be useful to add this test in your patches: a library could use another OPAC and do not want to have this link displayed. Since Owen is going to add another link ("Add to basket") to each entry, I think we will need a new pref to drive this display soon :)
Created attachment 52737 [details] [review] Bug 14790 [QA Followup] - Don't show links unless OPACBaseURL is set
(In reply to Jonathan Druart from comment #11) > In catalogue/detail.pl, we already have a "OPAC view" link (only for > non-XSLT views (?)). It tests if OPACBaseURL exists. It may be useful to add > this test in your patches: a library could use another OPAC and do not want > to have this link displayed. That's a good idea! Here's a followup to add that!
Actually it does not work, if you try and empty OPACBaseURL, it will contain "http://", so [% IF OPACBaseURL %] in tt is always true. Feel free to postpone this bugfix as it's already buggy in master.
(In reply to Jonathan Druart from comment #14) > Actually it does not work, if you try and empty OPACBaseURL, it will contain > "http://", so [% IF OPACBaseURL %] in tt is always true. > Feel free to postpone this bugfix as it's already buggy in master. Done, thanks for letting me know!
Created attachment 52890 [details] [review] Bug 14790 - Add Opac view link to search results Test Plan: 1) Apply this patch 2) Perform a staff catalog search 3) Note the new "OPAC view" link 4) Click the link, it should open a new tab to the OPAC details for that record. This works fine except that it doesn't open in a new tab. I don't think it's the fault of the patch, but of browser.js messing with links again (See Bug 11937). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 52891 [details] [review] Bug 14790 - Add OPAC view link to items editor Test Plan: 1) Apply this patch 2) Find a record and open the items editor for it 3) Click the "Actions" button for an item 4) Choose the option "OPAC view" 5) A new browser tab should open to the OPAC details page for the record whose items you are editing. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 52892 [details] [review] Bug 14790 - Add OPAC view link to Serials detail Test Plan: 1) Apply this patch 2) Browse to subscription-detail.pl for a given serial 3) Note the new "OPAC view" link 4) Click the link, a new tab should open up showing the record details for that record in the OPAC Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 52893 [details] [review] Bug 14790 [QA Followup] - Don't show links unless OPACBaseURL is set Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Kyle M Hall from comment #15) > (In reply to Jonathan Druart from comment #14) > > Actually it does not work, if you try and empty OPACBaseURL, it will contain > > "http://", so [% IF OPACBaseURL %] in tt is always true. > > Feel free to postpone this bugfix as it's already buggy in master. > > Done, thanks for letting me know! Actually I have filled bug 16813 and provided a patch. It seems better to fix it and keep your last patch. Hope that makes sense for you.
Pushed to master for 16.11!
Pushed in 16.05. Will be in 16.05.02.