There are three shortcuts or hotkeys in the Koha staff client: * Alt + U = Check out * Alt + R = Check in * Alt + Q = Search the catalog As I understand these shortcuts should work all over the staff client, and mostly they do. In Koha 3.20 though when going to Koha menu "Cataloging" they don't work as expected. Instead here the mapping is: * Alt + U = Search the catalog * Alt + R = Cataloging search * Alt + Q = Check out
Created attachment 42570 [details] [review] Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them.
I applied the patch manually in the files "cataloging-search.inc" and "patron-search.inc" of directory "/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/de-DE/includes" and the patch works as expected.
Created attachment 42585 [details] [review] Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
You might check the serials module tabs as well. :)
(In reply to Liz Rea from comment #4) > You might check the serials module tabs as well. :) Yes, it looks good. But, even without this patch :) Why did you say that?
Because when I was looking at it the other day, it seemed like it was acting weirdly, but I take your word for it that it's ok. :)
Created attachment 42981 [details] [review] [PASSED QA] Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!