Added new cron script "send membership expiry reminder notices" in crontab.example file.
Created attachment 42634 [details] [review] Bug 14840 Added new cron script send membership expiry reminder notices in crontab.example file Added new cron script send membership expiryreminder notices in crontab.example file
Robin: This cronjob is actually optional. Should we add it on a commented line to debian/koha-common.cron.daily ?
Created attachment 42651 [details] [review] Bug 14840 Added new cron script send membership expiry reminder notices in crontab.example file Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Taking the liberty to move this to the next level right away. Only documentation. Passed QA
(In reply to Marcel de Rooy from comment #2) > Robin: This cronjob is actually optional. > Should we add it on a commented line to debian/koha-common.cron.daily ? So, in general I'm not a big fan of having people configure things by editing crontab files. In particular, it's hard for shared hosting. The ideal would be that the cronjob always runs and there's something (a syspref or whatever) that determines if it's enabled for a particular instance. However, doing that is clearly out of scope for a simple patch like this, so yeah, a commented out entry in debian/koha-common.cron.daily would be fine.
(In reply to Robin Sheat from comment #5) > (In reply to Marcel de Rooy from comment #2) > > Robin: This cronjob is actually optional. > > Should we add it on a commented line to debian/koha-common.cron.daily ? > > So, in general I'm not a big fan of having people configure things by > editing crontab files. In particular, it's hard for shared hosting. The > ideal would be that the cronjob always runs and there's something (a syspref > or whatever) that determines if it's enabled for a particular instance. > > However, doing that is clearly out of scope for a simple patch like this, so > yeah, a commented out entry in debian/koha-common.cron.daily would be fine. Thanks, Robin. Amit: If your pref would default to zero and this would mean "do nothing" and a nonzero value would trigger the process, we could just always run the script. What do you think ?
Created attachment 42701 [details] [review] Bug 14840 Added new cron script send membership expiry reminder notices in crontab.example file Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: Added koha-common.cron.daily. Note that the cronjob only does something when the pref is set now. See corresponding change on bug 6810.
Patch pushed to master. Thanks Amit!