No idea how to replicate this issue but we have been getting several reports about the following error: Software error: Corrupted storable string (binary v2.9) at /usr/lib/perl/5.18/Storable.pm line 417, at /home/koha/kohaclone/cataloguing/additem.pl line 375. This patch prevents the whole program from dying, because this error is not critical enough to warrant dying. Also there is no centralized mechanism in Koha for showing messages to the user, so there is no easy and convenient way to warn the user that the: 'LastCreatedItem'-cookie or the systempreference 'PrefillItem' is malfunctioning. So we instead just warn to the server logs with the malfunctioning cookie in hopes of nailing down what causes the issues.
Created attachment 42644 [details] [review] Bug 14844 - Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. No idea how to replicate this issue but we have been getting several reports about the following error: Software error: Corrupted storable string (binary v2.9) at /usr/lib/perl/5.18/Storable.pm line 417, at /home/koha/kohaclone/cataloguing/additem.pl line 375. TEST PLAN: 1. Add or modify an Item. 2. No observed changes. ?. We don't know what causes this but we know that add/modify Item occasionally crashes due to failure of a cookie thawing. This patch prevents the whole program from dying, because this error is not critical enough to warrant dying. Also there is no centralized mechanism in Koha for showing messages to the user, so there is no easy and convenient way to warn the user that the: 'LastCreatedItem'-cookie or the systempreference 'PrefillItem' is malfunctioning. So we instead just warn to the server logs with the malfunctioning cookie in hopes of nailing down what causes the issues.
I've already seen that. What web server do you use? and what browsers?
Maybe the error occurs when the cookie is created (line 479). Just a guess after reading: http://stackoverflow.com/questions/1384702/should-i-use-storable-or-freezethaw-to-serialize-perl-data-as-a-cookie-value
Created attachment 53779 [details] [review] Bug 14844: Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. No idea how to replicate this issue but we have been getting several reports about the following error: Software error: Corrupted storable string (binary v2.9) at /usr/lib/perl/5.18/Storable.pm line 417, at /home/koha/kohaclone/cataloguing/additem.pl line 375. TEST PLAN: 1. Add or modify an Item. 2. No observed changes. ?. We don't know what causes this but we know that add/modify Item occasionally crashes due to failure of a cookie thawing. This patch prevents the whole program from dying, because this error is not critical enough to warrant dying. Also there is no centralized mechanism in Koha for showing messages to the user, so there is no easy and convenient way to warn the user that the: 'LastCreatedItem'-cookie or the systempreference 'PrefillItem' is malfunctioning. So we instead just warn to the server logs with the malfunctioning cookie in hopes of nailing down what causes the issues. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 53833 [details] [review] Bug 14844: Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. No idea how to replicate this issue but we have been getting several reports about the following error: Software error: Corrupted storable string (binary v2.9) at /usr/lib/perl/5.18/Storable.pm line 417, at /home/koha/kohaclone/cataloguing/additem.pl line 375. TEST PLAN: 1. Add or modify an Item. 2. No observed changes. ?. We don't know what causes this but we know that add/modify Item occasionally crashes due to failure of a cookie thawing. This patch prevents the whole program from dying, because this error is not critical enough to warrant dying. Also there is no centralized mechanism in Koha for showing messages to the user, so there is no easy and convenient way to warn the user that the: 'LastCreatedItem'-cookie or the systempreference 'PrefillItem' is malfunctioning. So we instead just warn to the server logs with the malfunctioning cookie in hopes of nailing down what causes the issues. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Marking as Major, as it breaks production sites on upgrade.
Pushed to master for 16.11, thanks Olli!
Pushed in 16.05. Will be in 16.05.03.
Pushed to 3.22.x, will be in 3.22.10
Why not empty the cookie if corrupted ?