Bug 14853 - Change "Fund" to "Shipping fund" where appropriate
Summary: Change "Fund" to "Shipping fund" where appropriate
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
: 14852 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-18 14:22 UTC by Nicole C. Engard
Modified: 2017-06-14 22:05 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14853: Change 'Fund' to 'Shipping fund' (2.21 KB, patch)
2015-11-22 01:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 14853: Change 'Fund' to 'Shipping fund' (2.44 KB, patch)
2015-12-15 13:12 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 14853: Change 'Fund' to 'Shipping fund' (2.50 KB, patch)
2015-12-18 11:31 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2015-09-18 14:22:04 UTC
When looking on the receipt page in acquisitions it says 'Shipping cost' and then 'Fund' below that.  The fund is for the shipping cost and people don't always realize that. I thank it should say 'Shipping Fund' or some such thing to make it clear.
Comment 1 Kyle M Hall 2015-09-18 14:41:21 UTC
*** Bug 14852 has been marked as a duplicate of this bug. ***
Comment 2 Katrin Fischer 2015-11-22 01:54:21 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2015-12-15 13:12:15 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2015-12-18 11:31:36 UTC
Created attachment 45816 [details] [review]
Bug 14853: Change 'Fund' to 'Shipping fund'

Changes the 'Fund' to 'Shipping fund' so it's clear
what the fund setting is used for.

To test:
- Receive a new shipment
- Verify that 'Shipping fund' displays on the parcels page
- Search for your invoice
- View invoice details
- Verify that 'Shipping fund' displays on the invoice page

Followed test plan (changed lines: '...cost' -> '...fund')
Display OK on both places.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2015-12-18 11:34:41 UTC
I am not convince about this change, it looks obvious that the fund is for the shipping cost, there is no other price on this page :)
Nicole and Katrin want this change, so I won't oppose to it.

Marc, I have removed the "---" line and added back your signed-off-by lines.
It has been removed when I apply the patch (Looks like it is used by git to separate message and diff parts).
Comment 6 Katrin Fischer 2015-12-18 12:22:54 UTC
Hi Jonathan - it's obvious to us, but I think every single one of our acquisition using libraries has been confused by it so far - renaming might not be the ultimate best solution, but it shoudl do the trick :)
Comment 7 Brendan Gallagher 2015-12-30 19:25:55 UTC
Pushed to Master - Thanks!
Comment 8 Julian Maurice 2015-12-31 13:22:58 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 9 Frédéric Demians 2015-12-31 18:33:41 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.