When looking on the receipt page in acquisitions it says 'Shipping cost' and then 'Fund' below that. The fund is for the shipping cost and people don't always realize that. I thank it should say 'Shipping Fund' or some such thing to make it clear.
*** Bug 14852 has been marked as a duplicate of this bug. ***
Created attachment 45082 [details] [review] Bug 14853: Change 'Fund' to 'Shipping fund' Changes the 'Fund' to 'Shipping fund' so it's clear what the fund setting is used for. To test: - Receive a new shipment - Verify that 'Shipping cost' displays on the parcels page - Search for your invoice - View invoice details - Verify that 'Shipping cost' displays on the invoice page
Created attachment 45698 [details] [review] Bug 14853: Change 'Fund' to 'Shipping fund' Changes the 'Fund' to 'Shipping fund' so it's clear what the fund setting is used for. To test: - Receive a new shipment - Verify that 'Shipping fund' displays on the parcels page - Search for your invoice - View invoice details - Verify that 'Shipping fund' displays on the invoice page --- Followed test plan (changed lines: '...cost' -> '...fund') Display OK on both places. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 45816 [details] [review] Bug 14853: Change 'Fund' to 'Shipping fund' Changes the 'Fund' to 'Shipping fund' so it's clear what the fund setting is used for. To test: - Receive a new shipment - Verify that 'Shipping fund' displays on the parcels page - Search for your invoice - View invoice details - Verify that 'Shipping fund' displays on the invoice page Followed test plan (changed lines: '...cost' -> '...fund') Display OK on both places. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I am not convince about this change, it looks obvious that the fund is for the shipping cost, there is no other price on this page :) Nicole and Katrin want this change, so I won't oppose to it. Marc, I have removed the "---" line and added back your signed-off-by lines. It has been removed when I apply the patch (Looks like it is used by git to separate message and diff parts).
Hi Jonathan - it's obvious to us, but I think every single one of our acquisition using libraries has been confused by it so far - renaming might not be the ultimate best solution, but it shoudl do the trick :)
Pushed to Master - Thanks!
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.