At line 73 of misc/misc/batchRebuildItemsTables.pl, we're skipping records whose $reclen is greater than 99999 bytes. if ($reclen > 99999) { push @errors, "bad record length for biblionumber $biblionumber (length : $reclen) "; next; } The 99999 byte limit is only valid for GRS-1, which has been removed from koha, therefore this limit should be removed.
Created attachment 42744 [details] [review] Bug 14858: removed record length limit test
Test plan: Import / Create a MARC record that is more than 99999 bytes (this can be done by creating many items; the 952 fields will bulk up the record). Manipulate the MARC on the large record so that some item fields (bulkmarcimport is a good candidate for creating and manipulating such a record). Run misc/batchRebuildItemsTables.pl, and note that item fields are not updated for the jumbo record. Apply the patch. Re-run misc/batchRebuildItemsTables.pl, and see that the item fields now match the jumbo record.
Created attachment 42942 [details] [review] Bug 14858: removed record length limit test Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Test plan was unclear, but here's what I did: 1 - Created a super big record (pasted a project gutenberg work into 520$b) 2 - Added items with $x - Non public and $z Public 3 - Mapped field x to items.itemnotes_nonpublic 4 - Checked mysql table, items.itemnotes_nonpublic was NULL 5 - Ran batchRebuildItemsTables.pl - received an error 6 - Checked mysql table, items.itemnotes_nonpublic was NULL 7 - Applied patch 8 - Ran batchRebuildItemsTables.pl - no error 9 - Checked mysql table, items.itemnotes_nonpublic was 'Non public' 10 - Signed off
Created attachment 43013 [details] [review] Bug 14858: removed record length limit test Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks for the test plan Nick!
Patch pushed to master. Thanks Barton!
Pushed to 3.20.x will be in 3.20.5