If a patron owes more than the system preference maxoutstanding in fees and fines, the patron will be unable to place holds via the opac. However, a librarian placing a hold for a patron is not even warned!
Created attachment 42811 [details] [review] Bug 14882 - Librarian's are not warned if patron owe more than maxoutstanding If a patron owes more than the system preference maxoutstanding in fees and fines, the patron will be unable to place holds via the opac. However, a librarian placing a hold for a patron is not even warned! Test Plan: 1) Apply this patch 2) Set amountoutstanding to 1.00 3) Find a patron owing more than 1.00 4) Attempt to place a hold 5) Note the warning that the patron owes money
Created attachment 42812 [details] [review] Bug 14882 - Librarian's are not warned if patron owe more than maxoutstanding If a patron owes more than the system preference maxoutstanding in fees and fines, the patron will be unable to place holds via the opac. However, a librarian placing a hold for a patron is not even warned! Test Plan: 1) Apply this patch 2) Set amountoutstanding to 1.00 3) Find a patron owing more than 1.00 4) Attempt to place a hold 5) Note the warning that the patron owes money
Created attachment 42813 [details] [review] Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds If a patron owes more than the system preference maxoutstanding in fees and fines, the patron will be unable to place holds via the opac. However, a librarian placing a hold for a patron is not even warned! Test Plan: 1) Apply this patch 2) Set amountoutstanding to 1.00 3) Find a patron owing more than 1.00 4) Attempt to place a hold 5) Note the warning that the patron owes money
Created attachment 42832 [details] [review] [Signed-off] Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds If a patron owes more than the system preference maxoutstanding in fees and fines, the patron will be unable to place holds via the opac. However, a librarian placing a hold for a patron is not even warned! Test Plan: 1) Apply this patch 2) Set maxoutstanding to 1.00 3) Find a patron owing more than 1.00 4) Attempt to place a hold 5) Note the warning that the patron owes money Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 42838 [details] [review] Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds If a patron owes more than the system preference maxoutstanding in fees and fines, the patron will be unable to place holds via the opac. However, a librarian placing a hold for a patron is not even warned! Test Plan: 1) Apply this patch 2) Set maxoutstanding to 1.00 3) Find a patron owing more than 1.00 4) Attempt to place a hold 5) Note the warning that the patron owes money Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have tried to standardize the way this is calculated, OPAC vs intranet, but it's out of the scope of this bug...
Patch pushed to master. Thanks Kyle!