Bug 14886 - Overdue notices: <<items.fine>> prints $0.00 when no fine exists.
Summary: Overdue notices: <<items.fine>> prints $0.00 when no fine exists.
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-24 12:28 UTC by Barton Chittenden
Modified: 2016-06-21 21:36 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2015-09-24 12:28:23 UTC
The <<items.fine>> markup will print $0.00, even when no accountlines entry exists which corresponds to the current borrower/itemnumber.

To test:

Set up circ rules for two item types (A and B). Make the loan duration the same for both, but only charge fines on item type A.

Set up overdue notices which include <<items.fine>>.

Set up notice triggers.

Check out items of types A and B, back-dating the check-out so that both items trigger today.

Run fines.pl by hand. Check accountlines database, make sure that there is a fines entry for the item of  type A.

Run overdue_notices.pl by hand. Inspect the generated notice. Item of type B will show a fine of $0.00.
Comment 1 Katrin Fischer 2015-09-29 21:34:03 UTC
Hi Barton,

I am not sure this is a bug.  I'd prefer something like:

Title of book
Fine: 0,00€

to

Title of book
Fine: 

in the overdue notices. The first seems clearer to the user for me.
Comment 2 Barton Chittenden 2015-09-29 22:20:08 UTC
(In reply to Katrin Fischer from comment #1)
> Hi Barton,
> 
> I am not sure this is a bug.  I'd prefer something like:
> 
> Title of book
> Fine: 0,00€
> 
> to
> 
> Title of book
> Fine: 
> 
> in the overdue notices. The first seems clearer to the user for me.

Fair point, given that we don't have any conditional logic within the notices themselves (in which case, leaving off 'Fine:' would be my preference).

If I were receiving a notice, I think that I would prefer

Title of book
Fine: --

over

Title of book
Fine: 0,00€

but that's a quibble. I'll close the bug.