14928 – Remove C4::Dates from files acqui/pdfformat/layout*.pm

Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm

Summary: Remove C4::Dates from files acqui/pdfformat/layout*.pm

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Marc Véron
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:	14870
	Show dependency tree / graph

Reported:	2015-09-30 13:56 UTC by Marc Véron
Modified:	2016-06-21 21:40 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
*Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout.pm** (3.42 KB, patch) 2015-09-30 14:11 UTC, Marc Véron	Details \| Diff \| Splinter Review
[COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl (5.51 KB, patch) 2015-10-01 09:13 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
*[SIGNED-OFF]Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout.pm** (3.52 KB, patch) 2015-10-08 21:17 UTC, Héctor Eduardo Castro Avalos	Details \| Diff \| Splinter Review
*Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout.pm** (3.58 KB, patch) 2015-10-09 08:33 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc Véron 2015-09-30 13:56:40 UTC

This patch removes C4::Dates from:
- acqui/pdfformat/layout2pages.pm
- acqui/pdfformat/layout2pagesde.pm
- acqui/pdfformat/layout3pages.pm
- acqui/pdfformat/layout3pagesfr.pm

Comment 1 Marc Véron 2015-09-30 14:11:56 UTC Comment hidden (obsolete)

Created attachment 42975 [details] [review]
Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm

This patch removes C4::Dates from:
- acqui/pdfformat/layout2pages.pm
- acqui/pdfformat/layout2pagesde.pm
- acqui/pdfformat/layout3pages.pm
- acqui/pdfformat/layout3pagesfr.pm

To test:
- Apply patch
- Go to Home > Acquisitions > [Vendor] > Basket groups
- Print a basket (order)
- Verify that the current date is formatted respects syspref 'dateformat'
- Do the same with syspref 'OrderPdfFormat' set to the four different choices

Comment 2 Jonathan Druart 2015-10-01 09:13:35 UTC Comment hidden (obsolete)

Created attachment 42991 [details] [review]
[COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl

This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It
also sent DateTime objects to the template, which use the TT plugin to
display them.
If an invalid dates is entered, the default date is picked.

Test plan:
1/ Go to Home > Circulation > Holds to pull
2/ Verify that the the filter and the list behave as before
3/ Enter invalid dates and confirm that you do not get a software error

Comment 3 Jonathan Druart 2015-10-01 09:14:18 UTC

Wrong bug report, sorry about that.

Comment 4 Héctor Eduardo Castro Avalos 2015-10-08 21:17:29 UTC Comment hidden (obsolete)

Created attachment 43286 [details] [review]
[SIGNED-OFF]Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm

This patch removes C4::Dates from:
- acqui/pdfformat/layout2pages.pm
- acqui/pdfformat/layout2pagesde.pm
- acqui/pdfformat/layout3pages.pm
- acqui/pdfformat/layout3pagesfr.pm

To test:
- Apply patch
- Go to Home > Acquisitions > [Vendor] > Basket groups
- Print a basket (order)
- Verify that the current date is formatted respects syspref 'dateformat'
- Do the same with syspref 'OrderPdfFormat' set to the four different choices

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Date printed in PDF Ok

Comment 5 Jonathan Druart 2015-10-09 08:33:43 UTC

Created attachment 43291 [details] [review]
Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm

This patch removes C4::Dates from:
- acqui/pdfformat/layout2pages.pm
- acqui/pdfformat/layout2pagesde.pm
- acqui/pdfformat/layout3pages.pm
- acqui/pdfformat/layout3pagesfr.pm

To test:
- Apply patch
- Go to Home > Acquisitions > [Vendor] > Basket groups
- Print a basket (order)
- Verify that the current date is formatted respects syspref 'dateformat'
- Do the same with syspref 'OrderPdfFormat' set to the four different choices

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Date printed in PDF Ok

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 6 Tomás Cohen Arazi (tcohen) 2015-10-09 14:30:07 UTC

Patch pushed to master.

Thanks Marc!