This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929)
Created attachment 42977 [details] [review] Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929)
Created attachment 43302 [details] [review] [SIGNED-OFF]Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref Dates in planning by months not needed to be on iso format, aqplan.pl uses instead Date::Calc
I get a software error if the dates are not correctly formatted.
Created attachment 43427 [details] [review] Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929)
The Follow-up needs an other sign-off.
Still applies
Sorry Marc, but fail me. This is the error message: DBIx::Class::ResultSet::find(): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= 'booksellerid' AND me.1 IS NULL AND me.2015-12-31 = 'contractname' AND me.Fict' at line 1 at /home/koha/kohaclone/C4/Contract.pm line 125 This happend me when modifing the contract and i've entered an invalid date 32/10/2015 (DD/MM/YY) This happen me when modifying the contract and entered an invalid date 32/10/2015 (DD/MM/YY)
Created attachment 43956 [details] [review] Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv
Created attachment 44101 [details] [review] [SIGNED OFF] Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv Signed-off-by: Jesse Weaver <pianohacker@gmail.com>
Created attachment 44103 [details] [review] Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref Dates in planning by months not needed to be on iso format, aqplan.pl uses instead Date::Calc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44104 [details] [review] Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44105 [details] [review] Bug 14931: (qa followu-up) small improvements - Avoid 1 call to dt_from_string in some cases - Do not use $_ Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44107 [details] [review] Bug 14931: Fix test xt/author/valid_templates complaining on opac-topissues.tt undef error - Undefined subroutine &C4::Languages::getlanguage called at C4/Koha.pm line 250. Test plan: prove xt/author/valid-templates.t
Patches pushed to master. Thanks Marc!