Bug 14948 - Display amounts right aligned in tables on patron pages
Summary: Display amounts right aligned in tables on patron pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-04 09:36 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14948 - Display amounts right aligned in tables on patron pages (8.46 KB, patch)
2015-10-04 09:46 UTC, Marc Véron
Details | Diff | Splinter Review
not aligned (14.23 KB, image/png)
2015-10-30 19:58 UTC, Nicole C. Engard
Details
Values right-aligned in checkout and detail tabs (73.96 KB, image/png)
2015-10-31 17:42 UTC, Marc Véron
Details
Bug 14948 - Display amounts right aligned in tables on patron pages (8.51 KB, patch)
2015-11-02 20:47 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 14948 - Display amounts right aligned in tables on patron pages (8.58 KB, patch)
2015-11-06 10:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 14948 - Display amounts right aligned in tables on patron pages (8.65 KB, patch)
2015-12-30 04:26 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-10-04 09:36:24 UTC
Amounts for charge, cine, price etc. appear left alinged (instead of right aligned) in tables on patron pages.
To verify:
- Go to Home > Patrons, perform a search (Column 'Fines')
- Go to a patron with fines and credits
  - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price'
    (maybe you have to show column with 'Show / hide colums')
  - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding'
  - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding'
Comment 1 Marc Véron 2015-10-04 09:46:56 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2015-10-30 19:58:25 UTC
On the patron details and the check out tab at the bottom the amounts are not right aligned.
Comment 3 Nicole C. Engard 2015-10-30 19:58:38 UTC
Created attachment 44259 [details]
not aligned
Comment 4 Marc Véron 2015-10-31 17:42:53 UTC
Created attachment 44268 [details]
Values right-aligned in checkout and detail tabs

I tested again with patch applied, the values are right-aligned, see screenshot.
Comment 5 Marc Véron 2015-10-31 17:48:32 UTC
BTW, I had to do a full browser reload (F5) after applying the patch to see the changes.
Comment 6 Nicole C. Engard 2015-11-02 20:47:47 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2015-11-06 10:40:53 UTC
Everything works fine, but I would prefer to see a css class defined to use everywhere.
Comment 8 Jonathan Druart 2015-11-06 10:42:03 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2015-11-06 10:42:32 UTC
(In reply to Jonathan Druart from comment #7)
> Everything works fine, but I would prefer to see a css class defined to use
> everywhere.

Let's say do it later.
Comment 10 Marc Véron 2015-12-01 15:11:40 UTC
Still applies.
Comment 11 Brendan Gallagher 2015-12-30 04:26:47 UTC
Created attachment 46066 [details] [review]
Bug 14948 - Display amounts right aligned in tables on patron pages

This patch set display amounts for charge, fine, price etc. right aligned in tables
on patron pages.

To test, apply patch and verify that amounts appear right aligned on following pages:

- Go to Home > Patrons, perform a search (Column 'Fines')
- Go to a patron with fines and credits
  - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price'
    (maybe you have to show column with 'Show / hide colums')
  - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding'
  - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding'
    Note: Test here 'Filter paid transactions' as well

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 12 Brendan Gallagher 2015-12-30 04:27:05 UTC
Pushed to Master - Thanks
Comment 13 Julian Maurice 2015-12-31 09:24:23 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 14 Frédéric Demians 2015-12-31 18:29:07 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.