This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t
Created attachment 43218 [details] [review] Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch).
Still applies
Created attachment 44008 [details] [review] [SIGNED-OFF] Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> NewsChanell pass for me before patch, no after. Followup follows :) Rest of tests pass
Created attachment 44009 [details] [review] Bug 14977: followup to fix NewsChanell.t With this patch test pass. To test: Run without and with the patch
Created attachment 44010 [details] [review] Bug 14977: followup to fix NewsChanell.t With this patch test pass. To test: Run without and with the patch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
The NewsChannels.t test fail for me, with and without the last patch: With: # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 90. # Structures begin differing at: # $got->{expirationdate} = '12/30/2999' # $expected->{expirationdate} = '30/12/2999' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 112. # Structures begin differing at: # $got->{expirationdate} = '12/31/2999' # $expected->{expirationdate} = '31/12/2999' # Looks like you failed 2 tests of 10. Without: # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 90. # Structures begin differing at: # $got->{expirationdate} = '30/12/2999' # $expected->{expirationdate} = '2999-12-30' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 112. # Structures begin differing at: # $got->{timestamp} = '01/01/2000' # $expected->{timestamp} = '2000-01-01' # Looks like you failed 2 tests of 10.
Comment on attachment 44010 [details] [review] Bug 14977: followup to fix NewsChanell.t Thanks Bernardo for the trying to fix. It helped to find out what happens. New patch follows.
Created attachment 44100 [details] [review] Bug 14977 - Followup to fix issue with NewsChannels.t The problem was that get_opac_new returns dates already syspref-formatted. To test: - Apply patch - Verify that t/db_dependent/NewsChannels.t does not fail.
Created attachment 44121 [details] [review] Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> NewsChanell pass for me before patch, no after. Followup follows :) Rest of tests pass Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44122 [details] [review] Bug 14977 - Followup to fix issue with NewsChannels.t The problem was that get_opac_new returns dates already syspref-formatted. To test: - Apply patch - Verify that t/db_dependent/NewsChannels.t does not fail. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed to master. Thanks Marc!