This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl
Created attachment 43315 [details] [review] Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron categorie like 'TEST' (usful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import.
Still appplies
Created attachment 43856 [details] [review] Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron categorie like 'TEST' (usful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Exported MARC data was the same with and without patch. Borrower import without patch (mis)calculated dates in wrong format, like 2010-30-12 in yyy-mm-dd becoming 2012-06-15. After the patch, default values were used instead. Data in correct format was imported as expected.
Created attachment 43937 [details] [review] [PASSED QA] Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron category like 'TEST' (useful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master Thanks Marc!